Skip to content

[DPC-5063] add safeguards to avoid using dev docker images in sandbox/prod #2861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukey-luke merged 3 commits into from
Jan 26, 2026
Merged

[DPC-5063] add safeguards to avoid using dev docker images in sandbox/prod #2861

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
660e4f9
add safeguards to avoid using dev docker images in sandbox/prod
lukey-luke Dec 17, 2025
b57552d
address PR issues - rls-r images only for upper envs
lukey-luke Jan 13, 2026
1ec84b2
Merge branch 'main' into ls/task-dpc-5063-ecr-images
lukey-luke Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/docker-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,7 @@ jobs:
id: login-ecr-prod
uses: aws-actions/amazon-ecr-login@062b18b96a7aff071d4dc91bc00c4c1a7945b076 # v2.0.1
- name: Push image to registries for prod aws account
if: ${{ !startsWith(needs.generate_docker_tag.outputs.docker_tag, 'rls-r') }}
env:
IMAGE_TAG: ${{ needs.generate_docker_tag.outputs.docker_tag }}
REGISTRY: ${{ steps.login-ecr-prod.outputs.registry }}
Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/ecs-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,13 @@ jobs:
echo "image_tag=$EXPLICIT_TAG" >> "$GITHUB_OUTPUT"
fi
echo $image_tag

- name: Fail if non-release image tag used for upper environments
if: ${{ (inputs.env == 'sandbox' || inputs.env == 'prod') && !startsWith(steps.image-tag.outputs.image_tag, 'rls-r') }}
run: |
echo "Dev image detected '${{ steps.image-tag.outputs.image_tag }}'. Tag must start with 'rls-r'."
exit 1

- uses: slackapi/slack-github-action@b0fa283ad8fea605de13dc3f449259339835fc52 # v2.1.0
name: Slack Starting
with:
Expand Down