DPC-5182 Add headings, error messages for login.gov signin fail states#2923
Merged
jhutchison-nava merged 8 commits intomainfrom Mar 6, 2026
Merged
DPC-5182 Add headings, error messages for login.gov signin fail states#2923jhutchison-nava merged 8 commits intomainfrom
jhutchison-nava merged 8 commits intomainfrom
Conversation
jhutchison-nava
force-pushed
the
jh/DPC-5182
branch
from
ab4c7ef to
4ab1188
Compare
Contributor
Jose-verdance
left a comment
Jose-verdance
left a comment
There was a problem hiding this comment.
Just a minor change, but looks good otherwise.
MEspositoE14s
previously approved these changes
Mar 6, 2026
Contributor
MEspositoE14s
left a comment
MEspositoE14s
left a comment
There was a problem hiding this comment.
Outside of @Jose-verdance's comment, 👍
MEspositoE14s
previously approved these changes
Mar 6, 2026
MEspositoE14s
previously approved these changes
Mar 6, 2026
dpc-portal/app/components/page/utility/error_component.html.erb
Outdated
Show resolved
Hide resolved
dpc-portal/app/components/page/utility/error_component.html.erb
Outdated
Show resolved
Hide resolved
jdettmannnava
dismissed stale reviews from Jose-verdance and MEspositoE14s
via
484934a
Co-authored-by: jdettmannnava <145699825+jdettmannnava@users.noreply.github.com>
MEspositoE14s
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/DPC-5182
🛠 Changes
Login.gov flow cancel
Login.gov flow fail
ℹ️ Context
These pages were missing h1's, causing an accessibility error
🧪 Validation
Manually verified during development with Lookbook
A11y check
Accessibility login shows login failurea11y error