Merged
Conversation
jhutchison-nava
force-pushed
the
jh/DPC-5177-button-link-fix
branch
3 times, most recently
from
258b879 to
6a9d10f
Compare
jhutchison-nava
force-pushed
the
jh/DPC-5177-button-link-fix
branch
from
6a9d10f to
c8b48a3
Compare
MEspositoE14s
previously approved these changes
Mar 5, 2026
Contributor
MEspositoE14s
left a comment
MEspositoE14s
left a comment
There was a problem hiding this comment.
Looks good on my local machine 👍
Contributor
jdettmannnava
left a comment
jdettmannnava
left a comment
There was a problem hiding this comment.
Probably out of scope, but added some fixes
dpc-portal/app/components/page/invitations/ao_flow_fail_component.html.erb
Outdated
Show resolved
Hide resolved
dpc-portal/app/components/page/invitations/success_component.html.erb
Outdated
Show resolved
Hide resolved
…pp into jh/DPC-5177-button-link-fix
jdettmannnava
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/DPC-5177
🛠 Changes
Updates button link/handling so that buttons that behaved as links are now just links
becomes
Also updates
button_tocomponent handling to set method back to the default of POST to avoid incorrect usage going forward.ℹ️ Context
We were incorrectly using submit buttons which behave differently than expected than links for screen reader users and those who use assistive technology. This makes links semantically consistent.
🧪 Validation
Verified during development using Lookbook
A11y check