Open
Conversation
jdettmannnava
changed the title
jscott-nava
approved these changes
Mar 6, 2026
| run: | | ||
| make ci-api-client | ||
| mkdir -p /usr/local/lib/docker/cli-plugins | ||
| curl -SL https://github.com/docker/compose/releases/download/v2.32.4/docker-compose-linux-x86_64 -o /usr/local/lib/docker/cli-plugins/docker-compose |
Contributor
There was a problem hiding this comment.
This is going to be a problem very shortly when the switch is made for CodeBuild to use arm64 runners (I believe happening this month due to annual pricing contracts). Either this should be updated to use arm64 or aarch64 here or in a ticket dedicated to making sure everything can build on arm64.
MEspositoE14s
approved these changes
Mar 6, 2026
Contributor
MEspositoE14s
left a comment
MEspositoE14s
left a comment
There was a problem hiding this comment.
All tests passing on my machine, LGTM!
Comment on lines
-26
to
-28
| In the api_client directory | ||
| ## Debugging and Development | ||
| To build an image, use the `make` command in the project root directory. | ||
| ```bash | ||
| $ make build |
Contributor
There was a problem hiding this comment.
Having this here and not in the root make file was a long standing pet peeve!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/DPC-5249
🛠 Changes
ℹ️ Context
A recent integration issue between the portal and dpc-api shows the need to have an integration test run as part of CI. Tests are based on the unit tests we already run.
We needed to switch to docker-compose to make it easy for the api-client to attach to the network running dpc-api.
As part of this effort, I realized that we were forcing JACOCO reporting via docker compose by default, so I changed the docker compose file to allow for not forcing JACOCO. I did a drive-by fix on docker-compose.base.yml to remove a WARNING.
🧪 Validation
CI passes.