Skip to content

suggest username when taken #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pebble-fish wants to merge 3 commits into
base: main
Choose a base branch
from
Open

suggest username when taken #4

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d64050
suggest username when taken
Feb 2, 2026
1b8d077
suggest username when taken
Feb 2, 2026
4202359
reverted things to task 3
Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion public/src/client/register.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,13 @@ define('forum/register', [
$('#username').trigger('focus');
};

// helper to build suggestion (task 2)
function suggestUsername(name) {
name = (name || '').trim();
if (!name) { return ''; }
return name + '0';
}

function validateUsername(username, callback) {
callback = callback || function () {};

Expand All @@ -135,7 +142,17 @@ define('forum/register', [
if (results.every(obj => obj.status === 'rejected')) {
showSuccess(usernameInput, username_notify, successIcon);
} else {
showError(usernameInput, username_notify, '[[error:username-taken]]');
// showError(usernameInput, username_notify, '[[error:username-taken]]');
const suggestion = suggestUsername(username);
const msg = suggestion ?
`That username is taken. Try "${suggestion}".` :
'That username is taken.';

showError(usernameInput, username_notify, msg);
if (suggestion) {
usernameInput.val(suggestion);
$('#yourUsername').text(slugify(suggestion));
}
}

callback();
Expand Down