Skip to content

fix Gem5-Ramulator fails with !req_stall assertion failure#34

Open
kvprathap wants to merge 1 commit intoCMU-SAFARI:masterfrom
kvprathap:master
Open

fix Gem5-Ramulator fails with !req_stall assertion failure#34
kvprathap wants to merge 1 commit intoCMU-SAFARI:masterfrom
kvprathap:master

Conversation

@kvprathap
Copy link

- Fixed write call back( This was not getting called).
   Since this is not called the inflight requests are never decremented after issueuing the writes.
    As a result, the numOutstanding() is always true.
- Issue retry, only when the queue is not full.

    - Fixed write call back.
    - Issue retry, only when the queue is not full.
@guillemlp
Copy link

I have had the same problem and fixed similarly. Now it works. However, if you are using TLDRAM you need to modify the same function (tick) in Controller.cpp.

@SaugataGhose
Copy link
Member

Thanks for catching this and pushing a fix! We will go through this and add changes to the TLDRAM tick() function, and merge these changes once we verify that we've addressed the problem fully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants