Skip to content

Conversation

FalcoGer
Copy link

@FalcoGer FalcoGer commented Dec 1, 2022

This PR adds argparse arguments instead of changing constants in the scripts all the time. Some constants can still be changed as default arguments for argparse.

This also adds a name == 'main' check for good form and puts the main code up top to make it more readable.

It also adds some type hints.

Other minor changes, like replacing a german name with an english one.

Adds argparse for arguments instead of changing file all the time
Adds type hints
adds argparse instead of constants
adds type hints to functions
@FalcoGer
Copy link
Author

FalcoGer commented Dec 7, 2022

I'd like to get rid of the repo, could you go over the changes and approve/edit/deny this PR please?

@goyalyashpal
Copy link

goyalyashpal commented Jan 21, 2023

I'd like to get rid of the repo, could you go over the changes and approve/edit/deny this PR please?

hey, you can try posting these further up the upstream, i.e. at https://github.com/RotBotSlicer/Transform ?

  • Though, yeah, it doesn't seem so active either...
  • probably there will be requirement of some "Conical Slicer Community" where people do maintain that. Similar to how there's https://github.com/ManimCommunity/manim/ for the original manim by Grantt.
  • but that ain't no easy undertaking either unless someone is willing for that

https://github.com/RotBotSlicer/Transform/network

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants