Skip to content

Clang tidy 1#644

Merged
CNugteren merged 34 commits intoCNugteren:masterfrom
EJainDev:clang-tidy-1
Nov 28, 2025
Merged

Clang tidy 1#644
CNugteren merged 34 commits intoCNugteren:masterfrom
EJainDev:clang-tidy-1

Conversation

@EJainDev
Copy link
Contributor

This implements the following performance related clang-tidy checks into the codebase and removes unnecessary lambda capture of V in xgemv.hpp:
[performance-unnecessary-copy-initialization]
[performance-unnecessary-value-param]
[performance-faster-string-find]
[performance-unnecessary-copy-initialization]

@CNugteren CNugteren merged commit da40932 into CNugteren:master Nov 28, 2025
6 checks passed
@CNugteren
Copy link
Owner

After merging this in there are some compilation errors on master:
https://github.com/CNugteren/CLBlast/actions/runs/19757215493
Not sure if this is related, not sure why this didn't show up here. I can investigate later, but if you have time @EJainDev feel free to look into it.

@EJainDev
Copy link
Contributor Author

@CNugteren I can’t see any direct things that would cause this because the PR did not affect the samples, which are throwing the error. Also, the error is only the clang + macOS run when compiling the samples. From what I see, there are 2 possible errors:

  1. macOS 13 is being deprecated which might have something to do with it
  2. The OpenCL C++ bindings recently changed to take references instead of pointers for non-optional arguments, which should be updated regardless. But there is no release containing this yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants