This repository was archived by the owner on Jul 1, 2022. It is now read-only.
Upgrade to bigchaindb 2.0#49
Open
excerebrose wants to merge 3 commits intoCOALAIP:masterfrom
ProvenanceLabs:master
Open
Upgrade to bigchaindb 2.0#49excerebrose wants to merge 3 commits intoCOALAIP:masterfrom ProvenanceLabs:master
excerebrose wants to merge 3 commits intoCOALAIP:masterfrom
ProvenanceLabs:master
Conversation
added 2 commits
November 19, 2018 15:18
1. Changed __init__ function to take in other parameters as well 2. Modified generate_user to suppport deterministic keypair generation 3. Modified get_status function to only response with valid, inline with API updates to BDB 4. Removed deprecated send() function and replaced with send_comit() 5. Updated Setup dependencies Test still pending, doing those now
1. test_order_transactions 2. test_order_transactions_is_correct_without_create
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Everything seems to be working fine,
however not confident with my updates to the tests in test_utils.py
also two tests are still failing in
test_utils.pytest_order_transactions&test_order_transactions_is_correct_without_createboth have the asset_id is None error, which I fixed in other tests by adding a fulfill_tx request but that doesnt work either for these.