Skip to content

Conversation

@djalova
Copy link
Collaborator

@djalova djalova commented Dec 18, 2020


Checklist:

  • Does this pull request close an issue? We encourage you to open an issue first if this pull request (PR) is not a
    minor change.
    • No
      • The change in this pull request is minor.
    • Yes
      • Closes issue in another repo

For the following questions, only check the boxes that are applicable.

  • Ensure that the pull request text above the horizontal line is descriptive.

  • Add/update relevant tests.

  • Add/update relevant documents.

  • Do you have triage permission of this repository?

    • No
      • You are good.
    • Yes
      • Does this pull request close an issue?
        • No, this pull request also acts as an issue by itself.
          • Assign yourself.
          • Label this pull request.
          • Put a milestone.
          • Put this pull request under "In Progress" or "Under Review" pipeline on ZenHub.
          • Put this pull request under the appropriate epic on ZenHub.
          • Put an estimate on ZenHub.
          • Add dependency relationship with other issues/pull requests on ZenHub.
        • Yes, this pull request addresses an issue and does not act as an issue.
          • Connect this pull request to the underlying issue on ZenHub.
          • DON'T:
            • DON'T assign yourself or anyone else.
            • DON'T label.
            • DON'T put a milestone.
            • DON'T put this pull request under any epic on ZenHub.
            • DON'T put an estimate on ZenHub.
      • When the pull request is ready, request review.

@djalova djalova added the dataset Add or update one or a few specific datasets label Dec 18, 2020
@djalova djalova added this to the Sprint 7 milestone Dec 18, 2020
@djalova djalova self-assigned this Dec 18, 2020
@djalova
Copy link
Collaborator Author

djalova commented Dec 18, 2020

Moving this into a separate PR from #5 since this dataset contains an XLSX file.

@xuhdev
Copy link
Collaborator

xuhdev commented Jan 8, 2021

Should we put this in post-release epic because it is blocked by a post-release epic issue?

@edwardleardi
Copy link
Collaborator

Yup good idea, just moved it there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dataset Add or update one or a few specific datasets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants