Properly configure hipCUB dependency #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmorel
force-pushed
the
hip-cub-dependency
branch
2 times, most recently
from
434f2cd to
2736329
Compare
Collaborator
|
@kmorel Thanks for adding the config logic for hipcub. Is this ready for merge? |
Contributor
Author
|
This PR matches the patches applied to the MGARD spack package in the spack/spack#48148 sister PR. It might be best to wait for @robertu94 to verify the code works in the spack package in that PR before merging this in. |
The HIP backend of MGARDX required the use of hipCUB. This is often installed with hip and will just be available, but it is not always. In the case where it is installed separately, make sure it is configured.
kmorel
force-pushed
the
hip-cub-dependency
branch
from
2736329 to
18a2fdb
Compare
Contributor
Author
|
@JieyangChen7 I'm now pretty confident that this is working as expected. You can review and merge when you are ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HIP backend of MGARDX required the use of hipCUB. This is often installed with hip and will just be available, but it is not always. In the case where it is installed separately, make sure it is configured.