Correct type for AbsMax reduction in HIP #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hip device collective for AbsMax does a reduction operation. The initial value was set to a literal int 0, which is wrong for floating types of arrays. This could cause wrong results or compile errors. Fixes CODARcode#241
Collaborator
|
@kmorel Thanks for discovering this issue! Can I merge this? |
Contributor
Author
|
@JieyangChen7 Yes. I'm doing one last spack compile (which takes hours) to reverify everything is working as expected, but I'm confident enough for you to merge this in. |
Contributor
Author
|
@JieyangChen7 FYI, I did my verification, and everything worked. This change is ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hip device collective for AbsMax does a reduction operation. The initial value was set to a literal int 0, which is wrong for floating types of arrays. This could cause wrong results or compile errors.
Fixes #241