Skip to content

Fix build with 3rd party programs when using HIP #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JieyangChen7 merged 1 commit into from
Mar 24, 2025
Merged

Fix build with 3rd party programs when using HIP #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions build_scripts/build_mgard_adios2_hip_frontier.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,18 @@
set -e
set -x

module load rocm/5.5.1
module load rocm/6.3.1
module load cmake

######## User Configurations ########
# Source directory
mgard_x_src_dir=.
# Build directory
build_dir=./build-hip-crusher
build_dir=./build-hip-frontier-adios2
# Number of processors used for building
num_build_procs=$1
# Installtaion directory
install_dir=./install-hip-crusher
install_dir=./install-hip-frontier-adios2

export LD_LIBRARY_PATH=$(pwd)/${install_dir}/lib:$LD_LIBRARY_PATH
export LD_LIBRARY_PATH=$(pwd)/${install_dir}/lib64:$LD_LIBRARY_PATH
Expand Down
2 changes: 1 addition & 1 deletion build_scripts/build_mgard_hip_frontier.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
set -e
set -x

module load rocm/5.5.1
module load rocm/6.3.1
module load cmake

######## User Configurations ########
Expand Down
15 changes: 15 additions & 0 deletions cmake/mgard-config.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,21 @@ if(@CUDAToolkit_FOUND@)
list(APPEND REQUIRED_VARS CUDAToolkit_FOUND)
endif()

if(@HIP_FOUND@)
find_dependency(HIP)
list(APPEND REQUIRED_VARS HIP_FOUND)
endif()

if(@rocprim_FOUND@)
find_dependency(rocprim)
list(APPEND REQUIRED_VARS rocprim_FOUND)
endif()

if(@hipcub_FOUND@)
find_dependency(hipcub)
list(APPEND REQUIRED_VARS hipcub_FOUND)
endif()

if(@MOAB_FOUND@)
find_dependency(MOAB)
list(APPEND REQUIRED_VARS MOAB_FOUND)
Expand Down
Loading