Skip to content

Conversation

@vaitkus
Copy link
Collaborator

@vaitkus vaitkus commented Feb 23, 2024

Closes #481.

@vaitkus vaitkus marked this pull request as draft April 4, 2024 09:53
@vaitkus vaitkus marked this pull request as ready for review April 4, 2024 12:25
@vaitkus
Copy link
Collaborator Author

vaitkus commented Apr 4, 2024

I have further updated the PR by adding the _alias.dictionary_version as discussed in #481. Note, that the pdbx/mmcif dictionary also has a similar attribute named _item_aliases.version.

See also PR #483 for an illustration of how the _alias.dictionary_uri and _alias.dictionary_version could be used in practice.

@vaitkus vaitkus requested a review from jamesrhester April 4, 2024 13:07
@vaitkus vaitkus requested a review from jamesrhester April 11, 2024 14:27
@jamesrhester jamesrhester merged commit 9b3960b into COMCIFS:master Apr 12, 2024
@vaitkus vaitkus deleted the clarify-semantics-of-alias-dictionary-uri branch April 12, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify the semantics of the _alias.dictionary_uri attribute

2 participants