Skip to content

Comments

Warn and skip if no smart chamber footer data#114

Merged
robertapeixoto merged 1 commit intomainfrom
handle-no-footer-data
Jan 23, 2026
Merged

Warn and skip if no smart chamber footer data#114
robertapeixoto merged 1 commit intomainfrom
handle-no-footer-data

Conversation

@bpbond
Copy link
Member

@bpbond bpbond commented Jan 23, 2026

@bpbond bpbond requested a review from robertapeixoto January 23, 2026 14:22
@bpbond
Copy link
Member Author

bpbond commented Jan 23, 2026

@robertapeixoto This changes the code so that observations with no 'footer' data (fluxes) get skipped. Is this the behavior you'd expect?

@robertapeixoto
Copy link
Contributor

robertapeixoto commented Jan 23, 2026

Yes, thanks, Ben! It is working great now and also showing us the list of obs with no 'footer' data in case we want to investigate them later. Awesome! Should I click "merge PR" on this review request (I don't want to mess up here)?

@robertapeixoto robertapeixoto merged commit 0838976 into main Jan 23, 2026
5 checks passed
@bpbond bpbond deleted the handle-no-footer-data branch January 23, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ffi_read_LIsmartchamber() fails when observations have differing row counts

2 participants