Execute "eslint --fix" #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR are the result of executing
eslint --fixwith the existing config files.A few extra outstanding (non-auto-fixable) linter errors were manually fixed (explained below).
A script was added to
package.jsonto facilitate future linting.Some rules, which were broken too commonly, were added and flagged as "to be ignored" in
.eslintrc. This file may need revision as it enforces a lot of unfollowed rules (Enforces "all rules", minus the dozen on the "ignore list").The original purpose of this PR is so that my upcoming PR's diff is more readable, since it comes with many unrelated formatting changes found here, which were done to satisfy my entirely-red IDE whom acknowledges the existing linter rules. Extra attention (manual linting fixes) was only given to a few files which will be part of my next PR and only adds linter rule compliance to otherwise untouched parts of the code. 99+% of the PR changes were simply from running
npm run test:lint-fix.There are 170 remaining (non-auto-fixable) linting errors after this PR.
Feel free to suggest the addition or removal of linting rules and I will amend this PR accordingly.