Closed
Conversation
Collaborator
There was a problem hiding this comment.
@ShangzhiXu
Hello,
Your approach seems fine and make sense to me. I shall take time reproducing your finding (threat) and if things fine then we can merge this patch.
These kinds of finding are very nice in term of secure coding, we now not just make things run, but make it run safely!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi team,
Regarding #793
I designed a new buffer to avoid the usage of origin argc and argv
More details in the second commit
Fix stack overflow in dlt-covert
it works on my machine to prevent the overflow
Before fix:
After fix
root@server:/home/shangzhi/fuz/fix/dlt-daemon/build-asan# ./poc.sh [*] Flooding directory with 5000 files...