Conversation
|
| } | ||
| } | ||
|
|
||
| m_file->close(); |
There was a problem hiding this comment.
when trying the feature, getting error "Unexpected EOF: file ends before message fully read." in application output.
Also, last few logs (20-100 lines) are missed. Data loss is seen when splitting the files.
Please test and correct the behaviour.
| // Reset to start | ||
| m_file->seek(0); | ||
|
|
||
| while (!m_file->atEnd()) { |
There was a problem hiding this comment.
Also this while look blocks UI thread, so if we try to split big file, the whole DLT-Viewer application is stuck and does not respond till the export is done. (which might take ~30-40 sec. in some cases.)
may be having thread safe implementation for this might help. if not, we can create a pop-up which show's the progress while export is going on.
| } | ||
|
|
||
|
|
||
| if (folderPath.isEmpty()) { |
There was a problem hiding this comment.
redundant empty checks.
| QString sizeUnit = unitCombo->currentText(); | ||
|
|
||
| qint64 multiplier = 1; | ||
| if (sizeUnit == "KB") multiplier = 1024LL; |
There was a problem hiding this comment.
I don't think KB split is really needed.
@mfukar what do you think?
| } | ||
|
|
||
| //call for spliting the DLT File | ||
| void MainWindow::on_actionSplitDLTFile_triggered(){ |
There was a problem hiding this comment.
please handle below cases
- After running DLT-Viewer first time if we trigger file split W/O opening any file, it causes a crash. We can give error popup saying no open file.
- start DLT -> connect to hw for live logs -> try to split the file (while connected/disconnected). -> split pop-up does not appear. We can give error popup saying save the file first.
The given dlt file can be split into smaller sizes and can be saved in local as per user's convenience Signed-off by : Renu Priya Krishnamoorthy <RenuPriya.KA.Krishnamoorthy@bti.bmwgroup.com>
File spliting into smaller sizes using DLT message. Logic removed from mainwindow and written to a new .cpp and .h file Signed-off by : Renu Priya Krishnamoorthy <RenuPriya.KA.Krishnamoorthy@bti.bmwgroup.com>
Renu-Priya411
force-pushed
the
Feature/ImproveFileSplittingSettings
branch
from
00b7edd to
a1509ce
Compare
4 participants
The given dlt file can be split into smaller sizes and can be saved in local as per user's convenience
Signed-off by : Renu Priya Krishnamoorthy RenuPriya.KA.Krishnamoorthy@bti.bmwgroup.com