Added some documentation for searchDialog #729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doxygen Documentation for searchDialog.cpp Signed-off by : Renu Priya Krishnamoorthy <RenuPriya.KA.Krishnamoorthy@bti.bmwgroup.com>
vifactor
reviewed
Sep 13, 2025
src/searchdialog.cpp
Outdated
| #include <QSignalBlocker> | ||
|
|
||
|
|
||
| /** |
Collaborator
There was a problem hiding this comment.
docstring comments are normally placed in header and not in implementation. Also formatting in many places git broken...
Author
There was a problem hiding this comment.
may i know what does formatting refer to ?
Collaborator
There was a problem hiding this comment.
this is what I see:
in any case, if you think that those docstrings are useful, move them to the corresponding header, otherwise it does not make any sense
Documenting the functions in searchDialog Signed-off by : Renu Priya Krishnamoorthy <RenuPriya.KA.Krishnamoorthy@bti.bmwgroup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doxygen Documentation for searchDialog.cpp
Signed-off by : Renu Priya Krishnamoorthy RenuPriya.KA.Krishnamoorthy@bti.bmwgroup.com