Conversation
spec/Powertrain/FuelSystem.vspec
Outdated
| type: actuator | ||
| description: Status of the fuel port flap(s). True if at least one is open. | ||
|
|
||
| InstantaneousFuelEconomy: |
There was a problem hiding this comment.
I would vote for grouping it in an Economy branch:
Economy:
type: branch
description: ...
Economy.Live:
...
Economy.Cumulative:
...
Economy.Drive:
...
Economy.SinceRefuel:
...There was a problem hiding this comment.
I suggest calling this signal InstantaneousFuelEconomy to match the existing signal InstantConsumption.
I have no strong opinion on if we should have them in a sub-branch. Can be discussed at the weekly meeting. But if so maybe we should also refactor the old signals, so that we e.g. get FuelEconomy.Instant and Consumption.Instant, i.e. same structure and naming for both.
There was a problem hiding this comment.
MoM:
- Ted: From FMS /Trucks - you may have multiple fuelsystems, do we want cumulative fueleconomy or separated by fuel tank.
- Erik: Think we should treat the "multi tank", "multi fuel" topic as a separate topic, PR/proposal welcome, related to Questions from FMS #859
- T: For ev there is a factor for cumulative, new unit recently added
- E: No need for subbranch
- Decision: Change
InstantaneousFuelEconomytoInstantantFuelEconomy - Then ok to merge
|
Thanks for the PR. I will bring it up at the next meeting Things to discuss:
|
|
MoM
|
|
MoM:
|
| This metric refreshes frequently and can fluctuate significantly based on driving conditions, acceleration, and terrain. | ||
| Unlike average fuel economy measurements, this provides immediate feedback on current driving efficiency. | ||
|
|
||
| CumulativeFuelEconomy: |
There was a problem hiding this comment.
A bit similar idea as AverageConsumption but I like this name better so lets keep it
| datatype: float | ||
| type: sensor | ||
| unit: km/l | ||
| description: Cumulative average fuel economy calculated from vehicle start or last user reset. |
There was a problem hiding this comment.
What is meant with "vehicle start" here? Start of current trip or during "vehicle lifetime". I assume it should be "during vehicle lifetime" unless user has manually reset the signal, because it should not be automatically reset at "engine start", or?
There was a problem hiding this comment.
It should not be automatically reset at 'engine start'. The cumulative fuel economy can only be reset when the vehicle battery is discharged or reset. Generally, during the vehicle's lifetime, the vehicle battery is not discharged or reset, and the battery can be considered to remain intact. Here, 'vehicle start' refers to a state where the battery is maintained without being discharged or reset.
There was a problem hiding this comment.
I think I understand it, so unless actively reset by user the value will be kept as long as possible, but may be implicitly reset if some battery is discharged or being replaced, if the system relies on always having power.
|
@InsangJang-ivis - in the last VSS meeting we agreed that it is ok to merge the PR if you do one change, so please update the PR:
|
erikbosch
left a comment
erikbosch
left a comment
There was a problem hiding this comment.
Name change needed for one signal
Signed-off-by: unknown <janginsang@ivis.ai>
InsangJang-ivis
force-pushed
the
add-fuel-economy-metrics
branch
from
24fd944 to
cba72a6
Compare
Changed the signal name from InstantaneousFuelEconomy to InstantantFuelEconomy. |
Signed-off-by: unknown <janginsang@ivis.ai>
3 participants
Add fuel economy metrics.