Merged
Conversation
Collaborator
|
While I am definitely not a Fahrenheit user myself, I guess it makes sense to have it in units.... Small nitpick/note: In this PR I see "Fahrenheit" capitalised in "definition" and "unit", while "celsius" ist not, it is not consistent, but I think the correct fix for tht is capitalising "Celsius" instead of modifying this PR |
Collaborator
|
MoM:
|
Contributor
Author
|
According to #868, the key introduced in this PR, “fahrenheit,” should ideally be updated to “Fahrenheit” for consistency. However, since this decision is still under discussion, I’ll hold off on making that change for now. |
Collaborator
|
MoM:
|
Signed-off-by: hyojun.an <anhj2473@ivis.ai>
ivis-Hyojun
force-pushed
the
add-unit-fahrenheit
branch
from
9f02bb0 to
70fcd2f
Compare
Contributor
Author
|
Capitalization has been updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add "fahrenheit" to temperature section of units.yaml