Skip to content

RPM in float instead of int cf Issue 827 #871

Merged
erikbosch merged 2 commits intoCOVESA:masterfrom
tguild:master
Dec 18, 2025
Merged

RPM in float instead of int cf Issue 827 #871
erikbosch merged 2 commits intoCOVESA:masterfrom
tguild:master

Conversation

@tguild
Copy link
Contributor

@tguild tguild commented Dec 9, 2025

Created PR of this minor change as discussed earlier

#827

@erikbosch
Copy link
Collaborator

MoM:

  • Ted presented the PR
  • Stefan: There could be multiple motors
  • T: yes being discussed, stuff coming up
  • Charles: Should also be float for electric?
  • T: Yes, can that do it in a separate PR, can have PR done tomorrow
  • OK to merge when PR updated as it has been discussed before

@tguild tguild force-pushed the master branch 2 times, most recently from 6989860 to ab78511 Compare December 16, 2025 15:44
@erikbosch
Copy link
Collaborator

@tguild - can you rebase on latest master. Think I solved the regression there

tguild and others added 2 commits December 16, 2025 12:24
Signed-off-by: Ted Guild <edwardguild@geotab.com>
Signed-off-by: Ted Guild <edwardguild@geotab.com>
@tguild
Copy link
Contributor Author

tguild commented Dec 16, 2025

@erikbosch thanks, after rebasing regression tests are clean

@erikbosch erikbosch merged commit a9d2148 into COVESA:master Dec 18, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants