Skip to content

[DDING-125-2] 섹션 여러 개일 경우 사용자 폼지 조회 수정 #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Seooooo24 merged 3 commits into from
Mar 12, 2025
Merged

[DDING-125-2] 섹션 여러 개일 경우 사용자 폼지 조회 수정 #296

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
538bda4
fix: 섹션 여러 개일 경우 사용자 폼지 조회 수정
Seooooo24 Mar 9, 2025
5185d85
refactor: 불필요한 괄호 제거
Seooooo24 Mar 9, 2025
e9c5a86
test: 섹션별 폼지 상세조회 테스트 작성
Seooooo24 Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/main/java/ddingdong/ddingdongBE/domain/form/repository/FormFieldRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,10 @@ SELECT f.id AS id, f.question AS question, f.field_type AS type, f.section AS se
SELECT *
FROM form_field f
WHERE f.form_id = :formId
AND (f.section = :section OR f.section = :defaultSection)
AND f.section = :section
""", nativeQuery = true)
List<FormField> findAllByFormAndSection(
@Param("formId") Long formId,
@Param("section") String section,
@Param("defaultSection") String defaultSection
@Param("section") String section
);
}
4 changes: 1 addition & 3 deletions src/main/java/ddingdong/ddingdongBE/domain/form/service/GeneralFormFieldService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
@Transactional(readOnly = true)
public class GeneralFormFieldService implements FormFieldService {

private static final String FORM_DEFAULT_SECTION = "공통";

private final FormFieldRepository formFieldRepository;

@Transactional
Expand Down Expand Up @@ -44,6 +42,6 @@ public void deleteAll(List<FormField> originFormFields) {

@Override
public List<FormField> getAllByFormAndSection(Form form, String section) {
return formFieldRepository.findAllByFormAndSection(form.getId(), section, FORM_DEFAULT_SECTION);
return formFieldRepository.findAllByFormAndSection(form.getId(), section);
}
}