Skip to content

refactor: 총동연 월별 1위 동아리 목록 조회 API 제거#389

Merged
KoSeonJe merged 2 commits intodevelopfrom
refactor/DDING-000-remove-admin-ranking-winners
Feb 23, 2026
Merged

refactor: 총동연 월별 1위 동아리 목록 조회 API 제거#389
KoSeonJe merged 2 commits intodevelopfrom
refactor/DDING-000-remove-admin-ranking-winners

Conversation

@KoSeonJe
Copy link
Copy Markdown
Collaborator

🚀 작업 내용

  • 요구사항 삭제에 따라 총동연 월별 1위 동아리 목록 조회 API(GET /server/admin/feeds/ranking/last) 전체 제거
  • 관련 Controller, Service, Repository, DTO, 테스트 코드 일괄 정리
  • 다른 Admin Feed API(총동연 피드 랭킹 조회)에는 영향 없음

🤔 고민했던 내용

  • FeedMonthlyRankingRepository는 스케줄러(Plan 03)에서도 사용하므로 repository 자체는 유지하고, plan 04 전용 쿼리 메서드만 제거
  • GeneralFeedRankingService에서 FeedMonthlyRankingRepository 의존성이 getMonthlyWinners에서만 사용되어 필드 자체를 제거

💬 리뷰 중점사항

  • 다른 API(피드 랭킹, 이달의 현황 등)에 영향이 없는지 확인 부탁드립니다

🤖 Generated with Claude Code

요구사항 삭제에 따라 plan 04 관련 코드 전체 제거

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 23, 2026

Warning

Rate limit exceeded

@KoSeonJe has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 3 minutes and 27 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between c7dfa5a and 07257b8.

📒 Files selected for processing (11)
  • src/main/java/ddingdong/ddingdongBE/domain/feed/api/AdminFeedApi.java
  • src/main/java/ddingdong/ddingdongBE/domain/feed/controller/AdminFeedController.java
  • src/main/java/ddingdong/ddingdongBE/domain/feed/controller/dto/response/AdminFeedRankingWinnerResponse.java
  • src/main/java/ddingdong/ddingdongBE/domain/feed/repository/FeedMonthlyRankingRepository.java
  • src/main/java/ddingdong/ddingdongBE/domain/feed/service/FeedRankingService.java
  • src/main/java/ddingdong/ddingdongBE/domain/feed/service/GeneralFeedRankingService.java
  • src/main/java/ddingdong/ddingdongBE/domain/feed/service/dto/query/FeedRankingWinnerQuery.java
  • src/test/java/ddingdong/ddingdongBE/domain/feed/controller/AdminFeedControllerE2ETest.java
  • src/test/java/ddingdong/ddingdongBE/domain/feed/controller/dto/response/AdminFeedRankingWinnerResponseTest.java
  • src/test/java/ddingdong/ddingdongBE/domain/feed/service/GeneralFeedRankingServiceTest.java
  • src/test/java/ddingdong/ddingdongBE/domain/feed/service/dto/query/FeedRankingWinnerQueryTest.java
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch refactor/DDING-000-remove-admin-ranking-winners

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@KoSeonJe KoSeonJe changed the title refactor: [DDING-000] 총동연 월별 1위 동아리 목록 조회 API 제거 refactor: 총동연 월별 1위 동아리 목록 조회 API 제거 Feb 23, 2026
@KoSeonJe KoSeonJe merged commit ce5a287 into develop Feb 23, 2026
1 check passed
@KoSeonJe KoSeonJe deleted the refactor/DDING-000-remove-admin-ranking-winners branch February 23, 2026 08:09
@KoSeonJe KoSeonJe self-assigned this Feb 23, 2026
KoSeonJe added a commit that referenced this pull request Feb 28, 2026
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
(cherry picked from commit ce5a287)
@KoSeonJe KoSeonJe mentioned this pull request Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant