Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/shared/ui/assets/activityReport.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
13 changes: 13 additions & 0 deletions src/shared/ui/assets/cleaning.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
12 changes: 12 additions & 0 deletions src/shared/ui/assets/clubFeed.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 5 additions & 0 deletions src/shared/ui/assets/clubMember.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions src/shared/ui/assets/clubScore.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions src/shared/ui/assets/doubleArrow.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 5 additions & 0 deletions src/shared/ui/assets/faq.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions src/shared/ui/assets/handleApply.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
24 changes: 24 additions & 0 deletions src/shared/ui/assets/index.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import ActivityReport from './activityReport.svg';
import Add from './add.svg';
import ArrowDown from './arrow-down.svg';
import ArrowLeft from './arrow-left.svg';
Expand All @@ -6,25 +7,36 @@ import ArrowUp from './arrow-up.svg';
import Camera from './camera.svg';
import Chart from './chart.svg';
import Check from './check.svg';
import Cleaning from './cleaning.svg';
import Close from './close.svg';
import ClubFeed from './clubFeed.svg';
import ClubMember from './clubMember.svg';
import ClubScore from './clubScore.svg';
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요런 네이밍이 너무 도메인을 따라가는 네이밍이라 최대한 커먼하게 변수명 지어주시면 좋을 것 같아용

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

b497e64 수정했습니다!

import Dots from './dots.svg';
import DoubleArrow from './doubleArrow.svg';
import DownLoad from './download.svg';
import Drag from './drag.svg';
import Dustpan from './dustpan.svg';
import Etc from './etc.svg';
import Faq from './faq.svg';
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

개인적으로는 퀘스쳔마크라는 네이밍이 더 어울릴 것 같아요. faq라는 변수명으로 해당 아이콘이 잘 떠오르지 않는 것 같아서요!

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

52c8c38 수정했습니다

import File from './file.svg';
import HandleApply from './handleApply.svg';
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요기도 확장성을 고려했을 때 행위와 특정 도메인을 나타내는 변수명은 좋지 않은 것 같아요! book처럼 딱 떠오를 수 있는 직관적인 네이밍으로 바꿔보는거 어떠실까요??

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

b497e64 최대한 직관적으로 사용하기 편하게 변경했습니다!

import Information from './information.svg';
import JoinActivity from './joinActivity.svg';
import List from './list.svg';
import Loading from './loading.svg';
import Locate from './locate.svg';
import Manage from './manage.svg';
import NavbarArrow from './navbar-arrow.svg';
import New from './new.svg';
import Peoples from './peoples.svg';
import Pin from './pin.svg';
import PlusMinus from './plusminus.svg';
import Refresh from './refresh.svg';
import Repair from './repair.svg';
import Report from './report.svg';
import Score from './score.svg';
import ScoreAdjust from './scoreAdjust.svg';
import Search from './search.svg';
import ShortReport from './shortReport.svg';
import Trash from './trash.svg';
Expand Down Expand Up @@ -66,6 +78,18 @@ export const Icons = {
score: Score,
video: Video,
information: Information,
faq: Faq,
handleApply: HandleApply,
joinActivity: JoinActivity,
manage: Manage,
activityReport: ActivityReport,
clubFeed: ClubFeed,
clubMember: ClubMember,
clubScore: ClubScore,
doubleArrow: DoubleArrow,
repair: Repair,
cleaning: Cleaning,
ScoreAdjust: ScoreAdjust,
};

export type IconName = keyof typeof Icons;
Expand Down
Loading