[REFACTOR] MediaUpload, ImageGallery 컴포넌트 사용성개선 #82
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,24 @@ | ||
| import { useState, useEffect } from 'react'; | ||
|
|
||
| import { Flex } from '../Flex'; | ||
| import { Icon } from '../Icon'; | ||
|
|
||
| type Props = { | ||
| files: File[] | null; | ||
| previewUrls: string[]; | ||
| onRemoveFile: (index: number) => void; | ||
| multiple: boolean; | ||
| }; | ||
|
|
||
| export function MediaPreview({ files, previewUrls, onRemoveFile, multiple }: Props) { | ||
| if (!multiple) { | ||
| return <MediaPreviewItem file={files?.[0]} previewUrl={previewUrls[0]} />; | ||
| } | ||
| return ( | ||
| <div className="grid grid-cols-2 gap-2 md:grid-cols-3 md:gap-4"> | ||
| {previewUrls?.map((previewUrl, index) => ( | ||
| <div key={index} className="relative aspect-square"> | ||
| <MediaPreviewItem file={files?.[index]} previewUrl={previewUrl} /> | ||
| <button | ||
| type="button" | ||
| onClick={() => onRemoveFile(index)} | ||
|
|
@@ -31,17 +33,27 @@ export function MediaPreview({ files, previewUrls, onRemoveFile, multiple }: Pro | |
| } | ||
|
|
||
| type MediaPreviewItemProps = { | ||
| file?: File; | ||
| previewUrl: string; | ||
| }; | ||
| function MediaPreviewItem({ file, previewUrl }: MediaPreviewItemProps) { | ||
| const [isVideo, setIsVideo] = useState<boolean>(false); | ||
|
|
||
| useEffect(() => { | ||
| if (file) return setIsVideo(file.type.startsWith('video/')); | ||
| getMimeType(previewUrl).then((type) => { | ||
| if (type) setIsVideo(type.startsWith('video/')); | ||
| else setIsVideo(false); | ||
| }); | ||
| }, [file, previewUrl]); | ||
|
|
||
|
Comment on lines
+42
to
+49
There was a problem hiding this comment. HEAD 요청에 중단/정합성 처리 없음 — 언마운트/빠른 전환 시 상태 경쟁 조건과 불필요 네트워크 발생
AbortController로 취소를 지원하고 res.ok를 확인하세요. - useEffect(() => {
- if (file) return setIsVideo(file.type.startsWith('video/'));
- getMimeType(previewUrl).then((type) => {
- if (type) setIsVideo(type.startsWith('video/'));
- else setIsVideo(false);
- });
- }, [file, previewUrl]);
+ useEffect(() => {
+ if (file) {
+ setIsVideo(file.type.startsWith('video/'));
+ return;
+ }
+ const ac = new AbortController();
+ let cancelled = false;
+ getMimeType(previewUrl, ac.signal).then((type) => {
+ if (!cancelled) setIsVideo(Boolean(type?.startsWith('video/')));
+ });
+ return () => {
+ cancelled = true;
+ ac.abort();
+ };
+ }, [file, previewUrl]);
@@
-async function getMimeType(url: string): Promise<string | null> {
+async function getMimeType(url: string, signal?: AbortSignal): Promise<string | null> {
try {
- const res = await fetch(url, { method: 'HEAD' });
- return res.headers.get('Content-Type');
+ const res = await fetch(url, { method: 'HEAD', signal });
+ if (!res.ok) return null;
+ return res.headers.get('Content-Type');
} catch {
return null;
}
}추가로, 외부 CDN CORS 정책으로 HEAD가 막힐 수 있어 캐시(Map<url, mime>)를 두어 재시도/중복요청을 줄이는 것도 권장합니다. Also applies to: 73-80 |
||
| return ( | ||
| <Flex | ||
| justifyContent="center" | ||
| alignItems="center" | ||
| className="relative h-full w-full rounded-xl border border-gray-200 bg-gray-50" | ||
| > | ||
| {isVideo ? ( | ||
| <video | ||
| src={previewUrl} | ||
| controls | ||
|
|
@@ -50,10 +62,19 @@ function MediaPreviewItem({ file, previewUrl }: MediaPreviewItemProps) { | |
| ) : ( | ||
| <img | ||
| src={previewUrl} | ||
| alt={file ? `미리보기 ${file.name}` : '미리보기 이미지'} | ||
| className="h-full max-h-[500px] w-full max-w-[500px] object-contain" | ||
| /> | ||
| )} | ||
| </Flex> | ||
| ); | ||
| } | ||
|
|
||
| async function getMimeType(url: string): Promise<string | null> { | ||
| try { | ||
| const res = await fetch(url, { method: 'HEAD' }); | ||
| return res.headers.get('Content-Type'); | ||
| } catch { | ||
| return null; | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint 경고로 파이프라인 실패 — 구조 분해 할당으로 수정하고 불필요한 prop 전파 차단
아래처럼 구조 분해 + 나머지 전달로 해결하세요.
📝 Committable suggestion
🧰 Tools
🪛 GitHub Actions: Check Pull Request
[warning] 16-16: Step 'npm run lint' reported 1 ESLint warning: 'Must use destructuring assignment' in MediaUpload.stories.tsx:16:60. ESLint found too many warnings (maximum: 0). Process completed with exit code 1.
🤖 Prompt for AI Agents