Open
Conversation
KoSeonJe
reviewed
Jul 9, 2024
Contributor
There was a problem hiding this comment.
ERD도 함께 올려주시면 좋을 것 같습니다. 그리고 PR 제목에 본인 이름도 추가해주시면 좋을 것 같아요
먼저 기능 단위로 커밋을 쪼개는 습관을 들이는 것이 필요할 것 같습니다. 커밋을 쪼개는 기준은 개인마다 기준이 다르나 만약 하나의 기능을 커밋을 쪼갠다면 그 기준을 최대한 통일되게 지켜주시는 것이 좋은 것 같습니다.
로그인 구현은 선행 공부가 필요한 부분이 많아서, 먼저 CRUD를 많이 구현해보고, 다른 기능적인 부분이 담긴 API도 구현을 많이 해본 뒤 익숙해지면 그 때 해도 좋을 것 같습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://web.postman.co/workspace/My-Workspace~2dedf2be-4166-4b44-8ef9-a4e59a55e5aa/collection/29668110-5670d8ed-31eb-47ce-962b-9908ef9ebcfd?action=share&source=copy-link&creator=29668110