Merged
Conversation
This PR addresses potential errors in tuplets by raising a warning, it does not propose a solution or re-assignment but rather notifies the user about potentially problematic scores.
Export ornaments in MusicXML
…list of start-end times
… values in order to accommodate large scores
…et_div_field_to_int64 This pull request addresses an issue with limitations of using int32 for the `onset_div` field of a note array generated from a long and complex pieces (e.g., a piano concerto, etc.)
(cherry picked from commit 6982439)
This pull requests fixes a bug causing negative duration in ticks for performed notes.
This pull request fixes adjusting the `sound_off` of performed notes when there are tempo changes.
Follow MusicXML guidelines to parse `mxl` compressed files
ivnsp
reviewed
Sep 10, 2025
Collaborator
ivnsp
left a comment
ivnsp
left a comment
There was a problem hiding this comment.
Looks good to me and will accept after the outstanding issues are resolved
…y_time Segment and Export Performed Part into Multiple MIDI Files
Consistent MIDI channel default value of 0
mgrachten
previously approved these changes
Sep 12, 2025
Collaborator
mgrachten
left a comment
mgrachten
left a comment
There was a problem hiding this comment.
Assuming Ivan's review approval is pending his requested update, I'll approve.
fix integer casting for offset scores
Member
Author
Thanks @mgrachten! I updated the |
Unify Formatting in CHANGES.md
ivnsp
approved these changes
Sep 16, 2025
Collaborator
ivnsp
left a comment
ivnsp
left a comment
There was a problem hiding this comment.
Considering the latest merge addressed all outstanding issues I think this is ready for release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for version 1.7.0
This version introduces the following changes:
New Features
<tuplet-dot/>and<normal-dot/>tags when parsing tuplets #429PerformedPartobjects by time. Segment and Export Performed Part into Multiple MIDI Files #438iter_allto take an iterable of classes Allow cls parameter of iter_all to take an iterable of classes rather than a single class #457pathlib.PathtoPathLikeReapply addingpathlib.PathtoPathlike#465Bug fixes
save_score_midi#459Other
int64foronset_divin note arrays Accept int64 values for 'onset_div' in note array #442Part.iter_allSpeedupiter_all()withoutclsargument #451Todo