Skip to content

Version 1.8.0#480

Merged
CarlosCancino-Chacon merged 62 commits intomainfrom
develop
Feb 6, 2026
Merged

Version 1.8.0#480
CarlosCancino-Chacon merged 62 commits intomainfrom
develop

Conversation

@CarlosCancino-Chacon
Copy link
Member

@CarlosCancino-Chacon CarlosCancino-Chacon commented Feb 2, 2026

PR for Version 1.8.0

Changes

TODO

@huispaty huispaty requested review from huispaty and sildater and removed request for huispaty and sildater February 5, 2026 15:48
@huispaty huispaty dismissed their stale review February 6, 2026 09:29

Outdated review

huispaty
huispaty previously approved these changes Feb 6, 2026
Copy link
Collaborator

@huispaty huispaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR introduces several updates, primarily around versioning and packaging, along with a handful of fixes.

sildater and others added 2 commits February 6, 2026 11:24
…e tests

- Add root-alter import from MusicXML <root-alter> element
- Add root-alter export to MusicXML
- Add comprehensive test suite for ChordSymbol:
  - Unit tests for ChordSymbol class (sharp, flat, double alterations, bass, etc.)
  - MusicXML import tests using inline XML
  - Round-trip tests (export and re-import)
  - Test documenting backward-compatible kind text attribute behavior
- Skip bass round-trip test (bass import not yet implemented)
@mgrachten
Copy link
Collaborator

Sorry for being late to the party. I did some testing of this PR, and encountered a crash related to chord imports from musicxml. I created a PR for this: #488. Should we include this in 1.8.0?

@sildater sildater self-requested a review February 6, 2026 14:27
sildater
sildater previously approved these changes Feb 6, 2026
Copy link
Member

@sildater sildater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me! The tests run now also locally for everyone. As a last thing I removed some imports which are only used for deprecated python versions below 3.10 here

@CarlosCancino-Chacon
Copy link
Member Author

Great! Thanks @sildater and @huispaty! I updated the CHANGES.md file with the latest changes. Could you approve the PR? Then I can finally make the release

Copy link
Collaborator

@mgrachten mgrachten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@CarlosCancino-Chacon CarlosCancino-Chacon merged commit e01626b into main Feb 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants