Skip to content

User profile #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

User profile #33

wants to merge 8 commits into from

Conversation

patrickbartlett
Copy link
Contributor

Fixed issue with text boxes not working properly when accordions were created using functional components.

Screen Shot 2021-04-14 at 10 28 25 PM

glkidd
glkidd reviewed Apr 15, 2021
View reviewed changes
Copy link
Contributor

@glkidd glkidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks really good! I'm wondering if we maybe want to add some carrot icons on the drop downs so people know they're drop downs, it's kinda hard to tell that they are if you didn't already know.

@ShreyaTumma
Copy link
Contributor

It would be nice to have dropdown arrows. Otherwise everything looks really good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turrence turrence Awaiting requested review from turrence

@Michelle5102 Michelle5102 Awaiting requested review from Michelle5102

2 more reviewers

@ShreyaTumma ShreyaTumma ShreyaTumma approved these changes

@glkidd glkidd glkidd approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrickbartlett @ShreyaTumma @glkidd