TUR-60: Basic NavBar Drop down menu #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… main Updated#
joesobo
suggested changes
Mar 11, 2021
|
|
||
| const toggling = () => setIsOpen(!isOpen); | ||
|
|
||
| const onOptionClicked = value => () => { |
There was a problem hiding this comment.
same comment as for david
const functionName = (values) => {
body
}
| const onOptionClicked = value => () => { | ||
| setSelectedOption(value); | ||
| setIsOpen(false); | ||
| console.log(selectedOption); |
| <DropDownListContainer> | ||
| <DropDownList> | ||
| {options.map(option => ( | ||
| <ListItem onClick={onOptionClicked(option)} key={Math.random()}> |
There was a problem hiding this comment.
call onOptionClicked with arrow function
| } | ||
| `; | ||
|
|
||
| export const DropDownHeader = styled("div")` |
There was a problem hiding this comment.
why ("div") instead of div
| @@ -33,7 +34,8 @@ class NavBar extends Component { | |||
|
|
|||
| {auth.isAuthenticated ? ( | |||
| <UserRow> | |||
| <Name key={3}>{`Logged in as: ${userName}`}</Name> | |||
| {/* <Name key={3}>{`Logged in as: ${userName}`}</Name> */} | |||
| } | ||
|
|
||
| renderTableHeader() { | ||
| let header = Object.keys(this.state.students[0]) |
| @@ -0,0 +1,2 @@ | |||
| import styled from 'styled-components'; | |||
There was a problem hiding this comment.
remove this and other empty files in NewPage
| box-shadow: 0 1px 15px; | ||
| color: #FFFFE0; | ||
| border-radius: 20px; | ||
|
|
| box-sizing: border-box; | ||
| transform: translate(-50%, -50%); | ||
| box-shadow: 0 1px 15px; | ||
| color: #FFFFE0; |
There was a problem hiding this comment.
see if you can use palette in styles folder for colors
| height: 100vh; | ||
| background-position: center; | ||
| background-size: cover; | ||
| `; |
There was a problem hiding this comment.
clean up spacing. You can keep empty test files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created base drop down menu in the navbar