admin ui MVC set up #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khitran
reviewed
Mar 11, 2021
| databaseStatus.setName("Last Backup"); | ||
| databaseStatus.setValue(updated_date); | ||
| databaseStatusRepository.update(databaseStatus); | ||
|
|
There was a problem hiding this comment.
I think adding the date in two places was a backup thing?
|
|
||
| public class IndexViewModelPost { | ||
| //network statuses | ||
| /* private String networkStatus; |
There was a problem hiding this comment.
If we don't need this anymore we should delete
siriwans
commented
Mar 11, 2021
| this.messages = new ArrayList<>(); | ||
|
|
||
| if (databaseStatusesResponse.hasErrors()) { | ||
| Logger.error("UpdatesController-databasePost()","Failed to update statuses"); |
There was a problem hiding this comment.
should probably have a clearer error string
ghost
reviewed
Mar 11, 2021
Comment on lines
108
to
109
| List<? extends IDatabaseStatus> kitStatuses = databaseStatusRepository.findAll(DatabaseStatus.class); | ||
| response.setResponseObject(kitStatuses); |
There was a problem hiding this comment.
Shouldn’t this variable be named databaseStatuses?
There was a problem hiding this comment.
yes sir, gotta change this... done!
ghost
reviewed
Mar 11, 2021
| ds.setValue("connected"); | ||
| assertEquals("connected", ds.getValue()); | ||
| } | ||
| } |
There was a problem hiding this comment.
All the tests look good, they test exactly what we need right now
mmachiya
reviewed
Mar 11, 2021
Comment on lines
131
to
154
| /*List<? extends ISystemSetting> allSystemSettings = systemSettingRepository.findAll(SystemSetting.class); | ||
|
|
||
| try { | ||
| if(systemSettings == null){ | ||
| //If systemSettings is null, that means that all settings buttons were unchecked. | ||
| for (ISystemSetting ss: allSystemSettings){ | ||
| ss.setActive(false); | ||
| systemSettingRepository.update(ss); | ||
| } | ||
| } else { | ||
| for (ISystemSetting ss : allSystemSettings) { | ||
| if (systemSettings.contains(ss.getName())) { | ||
| ss.setActive(true); | ||
| systemSettingRepository.update(ss); | ||
| } else { | ||
| ss.setActive(false); | ||
| systemSettingRepository.update(ss); | ||
| } | ||
| } | ||
| response.setResponseObject(allSystemSettings); | ||
| } | ||
| } catch (Exception ex) { | ||
| response.addError("", ex.getMessage()); | ||
| }*/ |
There was a problem hiding this comment.
remove commented out code if no longer needed
|
|
||
| ServiceResponse<List<? extends IKitStatus>> kitStatusesResponse = updatesService.retrieveKitStatuses(); | ||
| if (kitStatusesResponse.hasErrors()) { | ||
| throw new RuntimeException(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Admin UI MVC setup