Skip to content

fix: fix cloudflare deployment build script and clean pnpm references#13

Merged
Thanukamax merged 5 commits intomainfrom
CROW-136-https-github-com-crow-b-3-rogue-store-migrate-rogue-store-from-pnpm-to-bun
Dec 21, 2025
Merged

fix: fix cloudflare deployment build script and clean pnpm references#13
Thanukamax merged 5 commits intomainfrom
CROW-136-https-github-com-crow-b-3-rogue-store-migrate-rogue-store-from-pnpm-to-bun

Conversation

@Thanukamax
Copy link
Copy Markdown
Contributor

@Thanukamax Thanukamax commented Dec 21, 2025

Summary by CodeRabbit

  • Chores
    • Updated build configuration: default build now uses a cloud-optimized build tool and a separate Docker-specific build command was added.
    • Docker build pipeline adjusted to invoke the Docker-specific build step.
    • Cleaned Docker ignore entries to remove unnecessary files from Docker context.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 21, 2025

Warning

Rate limit exceeded

@Thanukamax has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 21 minutes and 51 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 56ef7de and 9d8135e.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • package.json (2 hunks)

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Updated build configuration: removed pnpm-related entries from .dockerignore; changed Dockerfile builder command from bun run build to bun run build:docker; updated package.json to run opennextjs-cloudflare build for scripts.build and added scripts["build:docker"] set to next build.

Changes

Cohort / File(s) Summary
Dockerignore
\.dockerignore
Removed .pnpm-store and pnpm-debug.log* entries.
Dockerfile
Dockerfile
Replaced builder-stage command bun run build with bun run build:docker.
Package scripts
package.json
Changed scripts.build to opennextjs-cloudflare build; added scripts["build:docker"] => next build.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Areas to check:
    • Confirm opennextjs-cloudflare CLI is available and invoked correctly in CI/deploy workflows.
    • Ensure Docker build uses the new bun run build:docker target as intended and matches build:docker script behavior.
    • Verify removal of .pnpm-store and pnpm-debug.log* from .dockerignore doesn't leak unwanted files into images.

Possibly related PRs

Suggested labels

area: infra, type: chore

Suggested reviewers

  • prdai
  • Methika1234

Poem

🐰 A hop through configs, light and quick,
I nudged the build, then hopped a tick.
Scripts aligned, the Docker hums,
Clean ignores and new build drums.
Happy hops — ship it quick! 🚀

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main changes: updating the Cloudflare deployment build script and removing pnpm references from .dockerignore.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Thanukamax Thanukamax self-assigned this Dec 21, 2025
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @Thanukamax, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses issues related to the Cloudflare deployment build process and cleans up outdated pnpm references. The changes ensure that the project's build commands are correctly configured for Cloudflare environments, both within the package.json scripts and the Dockerfile, while also tidying up the project's ignore files by removing entries no longer relevant to pnpm.

Highlights

  • Cloudflare Build Script Fix: The default 'build' script in package.json has been updated to use opennextjs-cloudflare build, aligning it with the Cloudflare-specific build process.
  • Dockerfile Build Command Update: The build command within the Dockerfile was changed from bun run build to next build to ensure correct execution during Docker image creation.
  • PNPM References Cleanup: References to pnpm-specific files and directories, such as .pnpm-store and pnpm-debug.log*, have been removed from both .dockerignore and .gitignore.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes the Cloudflare deployment build script by updating the build command in package.json and cleans up references to pnpm. The changes are logical and achieve the intended goal. I've added a couple of suggestions to improve the maintainability of the build scripts by centralizing them in package.json and removing a now-redundant script. Overall, these are good changes.

@cloudflare-workers-and-pages
Copy link
Copy Markdown
Contributor

cloudflare-workers-and-pages bot commented Dec 21, 2025

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
crow-rogue-store-dev 9d8135e Commit Preview URL

Branch Preview URL
Dec 21 2025, 04:39 PM

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3340f63 and 1182b3e.

📒 Files selected for processing (4)
  • .dockerignore (0 hunks)
  • .gitignore (0 hunks)
  • Dockerfile (1 hunks)
  • package.json (1 hunks)
💤 Files with no reviewable changes (2)
  • .gitignore
  • .dockerignore
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Workers Builds: crow-rogue-store-dev
🔇 Additional comments (1)
Dockerfile (1)

16-16: The Dockerfile is correctly configured for Docker Hub/standalone deployment, not Cloudflare Pages. The README explicitly states Cloudflare Pages is the deployment target, while the Dockerfile produces a Docker image for Docker Hub. The use of next build on line 16 is appropriate—it generates the .next/standalone output needed for traditional Node.js containerization. The difference from package.json's opennextjs-cloudflare build is intentional: each pipeline serves a different deployment target. No changes needed.

- Add 'build:docker' script to package.json for better maintainability
- Update Dockerfile to use 'bun run build:docker' instead of hardcoded 'next build'
- Keeps all build configurations centralized and easier to manage
…rogue-store-from-pnpm-to-bun' of https://github.com/CROW-B3/rogue-store into CROW-136-https-github-com-crow-b-3-rogue-store-migrate-rogue-store-from-pnpm-to-bun
- Change main 'build' script from 'opennextjs-cloudflare build' to 'next build'
  for general use and consistency with Docker build
- Upgrade @opennextjs/cloudflare from ^1.3.0 to ^1.14.7
- Keep 'build:cloudflare' for explicit Cloudflare Workers build
- Keep 'build:docker' for Docker image builds
- Wrangler will invoke 'build:cloudflare' when needed for Cloudflare deployment
- 'preview' and 'deploy' scripts continue to use opennextjs-cloudflare
- Ensures consistency between package.json scripts and Dockerfile
@Thanukamax Thanukamax added area: infra Infra, CI/CD, Terraform, Cloudflare, etc. priority: critical Immediate fix required; production-breaking labels Dec 21, 2025
@Thanukamax Thanukamax requested a review from prdai December 21, 2025 16:15
@Thanukamax Thanukamax merged commit 9f781ed into main Dec 21, 2025
4 checks passed
@Thanukamax Thanukamax deleted the CROW-136-https-github-com-crow-b-3-rogue-store-migrate-rogue-store-from-pnpm-to-bun branch December 21, 2025 16:37
@Thanukamax Thanukamax restored the CROW-136-https-github-com-crow-b-3-rogue-store-migrate-rogue-store-from-pnpm-to-bun branch December 21, 2025 16:37
prdai pushed a commit that referenced this pull request Mar 16, 2026
…3-rogue-store-migrate-rogue-store-from-pnpm-to-bun
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: infra Infra, CI/CD, Terraform, Cloudflare, etc. priority: critical Immediate fix required; production-breaking

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants