Skip to content

Feedback#1

Open
github-classroom[bot] wants to merge 107 commits intofeedbackfrom
main
Open

Feedback#1
github-classroom[bot] wants to merge 107 commits intofeedbackfrom
main

Conversation

@github-classroom
Copy link

@github-classroom github-classroom bot commented Aug 25, 2022

👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to main since the assignment started. Your teacher can see this too.

Notes for teachers Use this PR to leave feedback. Here are some tips: - Click the **Files changed** tab to see all of the changes pushed to `main` since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue **+** (plus sign). To learn more about comments, read “[Commenting on a pull request](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/commenting-on-a-pull-request)”. - Click the **Commits** tab to see the commits pushed to `main`. Click a commit to see specific changes. - If you turned on autograding, then click the **Checks** tab to see the results. - This page is an overview. It shows commits, line comments, and general comments. You can leave a general comment below. For more information about this pull request, read “[Leaving assignment feedback in GitHub](https://docs.github.com/education/manage-coursework-with-github-classroom/leave-feedback-with-pull-requests)”.

Subscribed: @ngchisern @ngzhenteng @github-amanda @yongxiangng

ngzhenteng and others added 30 commits October 18, 2022 16:28
…ed-features

Add interview/interviewee based functionality
* Except options request from authentication

* Fix changepassword, deleteaccount and logout apis

* Add resetpassword api to no need token list

* Authenticate logout api

* Update deleteaccount api format

* Fix deleteaccount api

* Fix ci
* Install react-codemirror

* Add simple editor

* Update coding event resp format

* Fix redundant update

* Tidy

* Remove monaco editor

* Remove monaco dependencies

* Update user service replica

* Add code mirror themes

* Fix themes

* Add language extension

* Tidy

* Deploy

* Deploy

* revert
* Trigger Deployment for debugging purposses

* Add upstream group for Nginx to proxy websocket connections using sticky sessions

* Trigger gatway image update

* Fix socket.io client join room logic in frontend

* Trigger frontend cd

* Trigger frontend cd after comm svc changes

* Remove unecessary cd lines

* Prevent CI from raising warning for useEffect
1. Added underline and modified color of hyperlinks shown at Login page
2. Made chat footer to be dynamic to zoom
* Add backend services

* Add attempts page skeleton

* Add table fetching

* Add pagination

* Fix pagination

* Add match history

* Add save question

* Fix nav bar format

* Add link to room page from attempts

* Fix attempt page

* Set values base on past attempt

* Add created at date

* Add backend message saving

* Save messages

* Fix config.js

* Test deploy

* Fix ci

* Test deploy

* Fix cd

* Update frontend-cd.yaml

* Add backend with usernames

* Update with username

* Use random time

* Set larget timeout

* Fix cd
* Fix layout of code editor and question display

* Update RoomPage.js

* Comment out unused stuff

* Fix logic of join room event

* Move chatSocket listeners into RoomPage

* Working popover chat

* Fix Saving of chat history

* fix ci

* Make client socket render only once, define listeners in separate useEffect

* Fix CI

* Make chat button draggable and add tooltip

* Update configs.js

Co-authored-by: Ng Zhen Teng <ngzhenteng@gmail.com>
* Fix question history

* Increase timeout

* Fix message async

* Fix ci

* Fix

* Update

* Update

* Fix configs.js

* Update
* Open port for https

* Deploy

* Revert "Deploy"

This reverts commit d8c3447.

* Route based on protocol

* Test frontend cd

* fix

* fix

* Test deploying build folder

* fix

* fix

* Improve

* Tidy

* Add live reloading in frontend
…ixes

Add 'End Session' confirmation dialog and removed 'Proceed Alone' option
* Add external link when viewing past attempt

* Ensure sockets do not connect when not live
* Add external link when viewing past attempt

* Ensure sockets do not connect when not live

* Fix auth issue for socket

* Fix ci
* Modifications to UI

* Removed unused imports

* update introduction
* Implement mq and test deploy

* Add secrets

* Apply new yaml

* Update deployment

* Increase memory limit

* Update deployment

* Update deployment

* Revert cd files

* Add ack upon receiving msg

Co-authored-by: ngchisern <ncsern2000@gmail.com>
* Add redis token store

* Working redis token store

* Update env.sample for user service, trigger docker image update for user service

* Trigger user-service image update

* Trigger cd

* Trigger cd

* Trigger cd

* Trigger cd

* Trigger cd

* Fix user-service env vars

* remove redis-config.yml

* Hide redis password

* Remove whitespace from user-service-cd

* Attempt to speed up logins by removing .exec() for mongoose calls

* Fix user-service-deployment

* Remove cd trigger for user-service-cd

* Add README for google pub sub instructions

* Move instructions to root README

* Make CI Ignore optional dependencies

* Attempt to fix CI
* Add redis svc for local dev

* Update env samples

* Add redis adapter

* Add deployment and service manifests

* Add env vars

* Increase replica

* Deploy

* Revert "Deploy"

This reverts commit d5800f0.
* Add background image, modify landing page

* Add difficulty cards

* Add questions to landing page

* Add Spinner for Login, remove past attempt button from profile menu

* Format Attempts Page.js

* Increase margin on login button

* Add peerprep logo

* Edit Room Page

* Remove entry in config.js pointing to live environment

* Fix background image problem with attempts page

* Fix CI

* Improve UI

* Fix ci

* Improve ui

* Refactor languages

* Update Logo

* Add spinner to reset page

* minor modifications to UI and added confirmation dialog

* Update DifficultyCard.js

Co-authored-by: ngchisern <ncsern2000@gmail.com>
Co-authored-by: Amanda Ang Yee Min <57126871+github-amanda@users.noreply.github.com>
* Increase user-service-deployment replica to 2, change env vars to ref secrets like all other deployments

* Add google cloud pub/sub integration for collab and comm svc

* Trigger CD for frontend, collab and comm svc to test deployment

* Fix frontend cd and ci

* Remove cd triggers, fix gke yamls

* Fix deployment collab and comm svc not working intermittently error

* Revert cd files

* Add longer delay timers as production may be slower

* Add Modal while chatSocket is connecting

* Trigger frontend deployment

* Decrease retry interval to 400ms, increase retry count to 20 times.

* Add longer timeout for websockets to not close on nginx

* Add proxy_connect_timeout

* Remove cd trigger for gateway-cd

* Increase retry count to 25 for safety, reduce match page timer to make matching look faster, chagne replica=1 for comm svc
… fix attempts page bug (#123)

* Store interviewer in redis, fix frontend chat modal bug, trigger cd for frontend and comm svc

* Remove cd triggers
* Update README

* Fix formatting

* Fix formatting

* Fix formatting

* Fix formatting

* Fix formatting

* Fix formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants