Skip to content

Conversation

KhoonSun47
Copy link

@KhoonSun47 KhoonSun47 commented Nov 15, 2024

Description

This Pull Request addresses an issue identified in our tsconfig.json file located at root/services/collaboration/src. The issue is preventing our collaboration service from compiling correctly. To resolve this, we propose adding these 2 lines of codes:

"allowJs": true,
"include": ["**/*.ts", "**/*.js"]

Context

Earlier this morning, my team (CS3219 Group 03) had a demo with Dr. Akshay using the deployed version of our PeerPrep website, which worked correctly. However, the latest commit on the repository caused a compilation issue in our collaboration service. This would impact the ability of the TA and Professor to test our code locally once we take down our deployed site to avoid exceeding our credit limit.

I have discussed this matter with TA Vishruti, and she advised us to create this PR with the proposed change for review.

Checklist

  • All tests passing

@KhoonSun47 KhoonSun47 added this to the Milestone 7 milestone Nov 15, 2024
@KhoonSun47 KhoonSun47 requested review from limcaaarl and samuelim01 and removed request for limcaaarl and samuelim01 November 15, 2024 11:19
@samuelim01 samuelim01 self-requested a review February 27, 2025 08:48
Copy link

@samuelim01 samuelim01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samuelim01 samuelim01 merged commit a4a1c0a into main Feb 27, 2025
6 checks passed
@samuelim01 samuelim01 deleted the fix-bug-1 branch February 27, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants