Feedback #1
Open
Feedback #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-classroom[bot]](https://avatars.githubusercontent.com/in/68187?s=60&v=4){kind=small}
No longer routes the user to another page. Users can add and submit new questions on the home page. Issues to fix: * Map frontend dynamic renders * Unify frontend and backend so dynamic rendering doesn't require mapping
Make add-feature Single Page
Modify UI to be similar to mockup
Update BE and FE
- Add Edit Modal (for Easy Questions only) - Update backend (UpdateQn)
- Previously, when one character is entered, one space will be inserted - Rename UpdateQn to EditQn to corresponds to the Edit button
Update Edit FE and BE
Include feature that stops a form from submitting if: - No Category, Title, Desc is submitted - If a Title is not unique Fix radio buttons allowing multi selection
Change checks for complexity to use strictly equals operator "==="
Show error message when any of the field is empty (except ID field)
Validate adding questions on FE and BE
Update Collab Space UI and Update timers
# Conflicts: # Frontend/src/components/question/Question.jsx
UI Changes
rayyan35p
force-pushed
the
main
branch
3 times, most recently
from
d092328 to
9f3184e
Compare
Update UI for sidebar
Update question title save for history
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to the default branch since the assignment started. Your teacher can see this too.
Notes for teachers
Use this PR to leave feedback. Here are some tips:
For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @ketamethane @RingoftheKing @yuxuanleong @qiaoen17 @rayyan35p