Feedback #1
Open
Feedback #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-classroom[bot]](https://avatars.githubusercontent.com/in/68187?s=60&v=4){kind=small}
API handlers are updated to support logging using Logrus. Go dependencies and .gitignore are updated accordingly.
Add home page with a filterable question list, along with some shared components.
Page is generic enough to be shared between pages, though it might be unlikely it will be shared? Depends on usecase.
Only handles errors right now - will implement layout soon.
PUT will attempt to replace a question with the stated ID with the new question. If the ID supplied is greater than what exists, a new question is inserted. In all operations, the replacement/insertion should not result in duplicate questions in the database.
Previously, the comms fix depended on the connected user handshaking on the endCall message, which gives a tiny window where another user could potentially reconnect and send out the joinRoom message before cleanup of the previous call is finished. This change places the room leaving algo before the endCall message within the same hook as the disconnecting message, which should help mitigate this latency window issue by preventing messages from propagating to the frontend while its still performing its cleanup.
Add a simple status message indicating no call started
2 is too short and could be due to latency
Now, it does a paranoid check against the room ID that initiated the room closure to prevent a close-room from affecting the 2nd user if they are in a different room already.
Fix navbar logout, middleware, room closure
Unify expiry handling with main collab-post-ms6 branch
Add online indicator status for collab editor, and fixed various other services
Deploy final
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
mainsince the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips:
mainsince the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.main. Click a commit to see specific changes.For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @rertyy @DistractedCat @modembcc @alvinlim277 @WZWren