Skip to content

(chore): Add live grading UI fixes #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Nov 8, 2024
Merged

(chore): Add live grading UI fixes #77

merged 21 commits into from
Nov 8, 2024

Conversation

SeeuSim
Copy link

@SeeuSim SeeuSim commented Nov 7, 2024 •
edited
Loading

Add:

  • dark mode bug fix
  • question attempt details code view fix
  • CRUD forms and APIs
  • Admin roles and associated crud UI (but not API guards, since question and user are sep services)

@SeeuSim SeeuSim marked this pull request as ready for review November 7, 2024 08:55
SeeuSim added 10 commits November 7, 2024 17:10
@SeeuSim
chore/ui: minimise layout shift for auth check
80f9959 
Signed-off-by: SeeuSim <[email protected]>
@SeeuSim
chore/ui: Add user dropdown
4ad7968 
Signed-off-by: SeeuSim <[email protected]>
@SeeuSim
chore/ui: try fix build bug
20e2030 
Signed-off-by: SeeuSim <[email protected]>
@SeeuSim
chore/ui: try fix build bug
11abbd8 
Signed-off-by: SeeuSim <[email protected]>
@SeeuSim
chore/ui: try fix build bug
32a77a0 
Signed-off-by: SeeuSim <[email protected]>
@SeeuSim
try fix build bug
39fb9dc 
Signed-off-by: SeeuSim <[email protected]>
@SeeuSim
try fix build bug
85afa58 
Signed-off-by: SeeuSim <[email protected]>
@SeeuSim
try fix build bug
e447e76 
Signed-off-by: SeeuSim <[email protected]>
@SeeuSim
try fix build bug
8ce07d4 
Signed-off-by: SeeuSim <[email protected]>
@SeeuSim
chore/ui: Add update form
1f80d09 
Signed-off-by: SeeuSim <[email protected]>
@SeeuSim SeeuSim force-pushed the chore/demo-ui-fixes branch from 8de9b39 to 1f80d09 Compare November 7, 2024 12:33
cyiting
cyiting reviewed Nov 8, 2024
View reviewed changes
Copy link

@cyiting cyiting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add validation to ensure that a question always has at least one topic associated with it. Currently we are able to add questions without topics and remove topics while editing

frontend/src/components/blocks/questions/admin-delete-form.tsx Outdated
<AlertDialogContent>
<AlertDialogHeader>
<AlertDialogTitle className='flex'>
Are you sure you want to delete question:&nbsp;`<pre>{questionId}</pre>`?
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove the backticks

@cyiting cyiting merged commit 845c555 into main Nov 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyiting cyiting cyiting approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SeeuSim @cyiting