Skip to content

Solomon/fix multiple code saved messages #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bensohh merged 3 commits into from
Nov 15, 2024
Merged

Solomon/fix multiple code saved messages #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
559af68
fix multiple code saved messages and submission or test case running …
solomonng2001 Nov 14, 2024
6b55beb
Resolve merge conflicts
solomonng2001 Nov 14, 2024
28871f9
Add info tool tip to clarify running test cases and submitting code
solomonng2001 Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/frontend/src/app/collaboration/[id]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ export default function CollaborationPage(props: CollaborationProps) {
customTestCases: "",
});
updateExecutionResults(data);
infoMessage("Test cases executed. Review the results below.");
successMessage("Test cases executed. Review the results below.");
sendExecutionResultsToMatchedUser(data);
} finally {
setIsLoadingTestCase(false);
Expand Down Expand Up @@ -500,6 +500,9 @@ export default function CollaborationPage(props: CollaborationProps) {
<div className="spinner-container">
{isLoadingSubmission && <Spin tip="Saving code..." />}
</div>
<Tooltip title="Submit will run public and hidden test cases before submitting">
<InfoCircleFilled className="submit-code" />
</Tooltip>
<Button
icon={<SendOutlined />}
iconPosition="end"
Expand Down
2 changes: 1 addition & 1 deletion apps/frontend/src/components/CollaborativeEditor/CollaborativeEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ const CollaborativeEditor = forwardRef(
state.editorState &&
state.editorState.id !== latestLanguageChangeId
) {
latestSubmissionId = state.editorState.id;
latestLanguageChangeId = state.editorState.id;
setSelectedLanguage(state.editorState.language);
// if (props.user === state.user.name) {
// console.log("ownself update ownself");
Expand Down
5 changes: 4 additions & 1 deletion apps/frontend/src/components/question/TestcaseDetail/TestcaseDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import {
InfoCircleFilled,
PlayCircleOutlined,
} from "@ant-design/icons";
import { Button, Input, Spin, Tabs, TabsProps, Typography } from "antd";
import { Button, Input, Spin, Tabs, TabsProps, Tooltip, Typography } from "antd";
import "./styles.scss";
import { isTestResult, Test } from "@/app/services/execute";

Expand Down Expand Up @@ -100,6 +100,9 @@ export const TestcaseDetail = (props: TestcaseDetailProps) => {
<div className="spinner-container">
{props.isLoadingTestCase && <Spin tip="Running test cases..." />}
</div>
<Tooltip title="Run test cases will run public test cases">
<InfoCircleFilled className="run-test-cases-info" />
</Tooltip>
<Button
icon={<PlayCircleOutlined />}
iconPosition="end"
Expand Down
Loading