Collab frontend #14
Collab frontend #14
Conversation
There was a problem hiding this comment.
Just a small minor bug in the editor where changing langauge does not actually change the syntax highlighting and suggestion.
For now it is ok but in future we should make it such that each language has its own state so that when change language it will disappear and reappear after they change it back.
additionally i notice a unnecessary scrollbar on the editor when the code is short and no need to scroll. but i feel that it may be the default library built in bug |
LemonDrew
dismissed
FooChao’s stale review
The merge-base changed after approval.
scroll till the last line
Bug has been fixed |
There was a problem hiding this comment.
LGTM! Collab page looks clean and easy to use. However, is it possible to include a short description for future PRs so it is easier for reviewers to identify the areas to look out for? @LemonDrew
Verified that scroll bar has been disabled when code does not exceed current screen height
Verified that language selector works as intended with correct syntax highlighting
Verified that collab page is only accessible by authenticated users
| import { ChevronRightIcon } from "lucide-react"; | ||
|
|
||
| export default function ChatComponent() { | ||
| const chatMessages = ["HELLO", "HOW ARE YOU?"]; |
There was a problem hiding this comment.
Noticed that there is some boiler plate chat messages here. Do you intend to render them for this PR, as its currently not rendered?
No description provided.