Open
Conversation
MiguelAFH
reviewed
Feb 13, 2025
Contributor
MiguelAFH
left a comment
MiguelAFH
left a comment
There was a problem hiding this comment.
My main concern with this PR is that we already have and onboarding and a weekly questionnaire. Users don't want to get into an app to do questionnaires all the time, so we should figure out a way to make these less often.
| { | ||
| "valueCoding": { | ||
| "code": "3", | ||
| "display": "3 - Moderately severe" |
Contributor
There was a problem hiding this comment.
You might want to check that the language used on this survey so that is standardize across all our surveys
Contributor
|
jennleww
approved these changes
Feb 13, 2025
Contributor
jennleww
left a comment
jennleww
left a comment
There was a problem hiding this comment.
- Please upload images of the UI after your changes, it is difficult to see the end result otherwise and we can't provide feedback.
- Have you checked the changes in QuestionnaireType go to different document collections in firebase?
- When you add a new resource, you need to add a .license file for that like we do for the other questionnaires. Otherwise you won't pass checks in the PR which prevent this from merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Name of the PR
♻️ Current situation & Problem
The app needs a daily morning check-in feature to track users' symptoms, with data stored in Firebase. This implements the morning check-in questionnaire and ensures proper data storage.
⚙️ Release Notes
Added daily morning check-in questionnaire scheduled for 8:00 AM
Integrated with Firebase storage under MorningCheckInQuestionnaireResponse collection
Updated EventView to handle both regular check-ins and morning check-ins
Added morningCheckIn case to QuestionnaireType enum
📚 Documentation
Added inline documentation for morning check-in task configuration in CoughSyncScheduler
Updated EventView with comments explaining questionnaire type determination
Firebase storage path documented in CoughSyncStandard
Added documentation for morning check-in UI components in ScheduleView
✅ Testing
Added comprehensive test coverage:
UI Tests in SchedulerTests.swift:
testMorningCheckIn(): Verifies morning check-in questionnaire flow
testQuestionnaireTypeDetermination(): Ensures correct questionnaire type assignment
testMorningCheckInWithFirebase(): Tests Firebase storage integration with emulator
Non-testable elements:
Real Firebase cloud storage (using emulator for testing)
Actual notification delivery (testing schedule configuration only)
Time-based triggers (verifying configuration, not actual timing)
All tests follow existing patterns in the codebase and maintain consistency with other feature tests.
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: