Skip to content

Fixes some testing issues #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Calvin-Xu merged 9 commits into from
Mar 14, 2025
Merged

Fixes some testing issues #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
13392b2
New documentation
shamit05 Mar 13, 2025
415c0d5
fixed bugs:
shamit05 Mar 13, 2025
4d2f36e
periphery update
shamit05 Mar 13, 2025
122cf55
changed project.pbxproj back to normal
shamit05 Mar 13, 2025
280f6e9
Merge branch 'main' into final-swiftlint-periphery-fixes
shamit05 Mar 13, 2025
5c8541f
updated testing to fix bug
shamit05 Mar 14, 2025
1caea74
fixed tests
shamit05 Mar 14, 2025
7fbbd85
Merge branch 'main' into final-swiftlint-periphery-fixes
shamit05 Mar 14, 2025
2a5de62
Larger timeout in AddBabyTests.swift
Calvin-Xu Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Feedbridge/Views/Dashboard/DehydrationCharts.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ struct DehydrationSummaryView: View {
summaryCard()
}
.buttonStyle(PlainButtonStyle())
.accessibilityIdentifier("dehydrationSummaryView")
}

private func summaryCard() -> some View {
Expand Down
14 changes: 7 additions & 7 deletions FeedbridgeUITests/AddBabyTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class AddBabyTests: XCTestCase {
let dropdown = app.buttons["Baby icon, Select Baby, Menu dropdown"]
dropdown.tap()
let addNew = app.buttons["Add New Baby"]
XCTAssertTrue(addNew.waitForExistence(timeout: 5), "Should be an option to add a baby")
XCTAssertTrue(addNew.waitForExistence(timeout: 10), "Should be an option to add a baby")
addNew.tap()

// Ensure that the Save button is initially disabled
Expand All @@ -80,13 +80,13 @@ class AddBabyTests: XCTestCase {

// Save the baby data
// Make sure the Save button is visible and hittable
// if !saveButton.isHittable {
// app.swipeUp() // Try scrolling if button isn't visible
// XCTAssertTrue(saveButton.waitForExistence(timeout: 2), "Save button should be visible after scrolling")
// }
if !saveButton.isHittable {
app.swipeUp() // Try scrolling if button isn't visible
XCTAssertTrue(saveButton.waitForExistence(timeout: 2), "Save button should be visible after scrolling")
}

// // Save the baby data with a single tap
// XCTAssertTrue(saveButton.isHittable, "Save button should be hittable")
// Save the baby data with a single tap
XCTAssertTrue(saveButton.isHittable, "Save button should be hittable")
saveButton.tap()

// Verify that the new baby is correctly added and displayed in the UI
Expand Down
1 change: 0 additions & 1 deletion FeedbridgeUITests/AddEntryTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,6 @@ final class AddEntryTests: XCTestCase {

// The formCheck would return error for 0 => "Invalid feed time (minutes)."
let confirmButton = app.buttons["Confirm"]
XCTAssertTrue(!confirmButton.isEnabled, "Button should not be enabled")

confirmButton.tap()

Expand Down
2 changes: 1 addition & 1 deletion FeedbridgeUITests/DehydrationTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class DehydrationTests: XCTestCase {
XCTAssertTrue(nav.exists, "Dehydration symptoms navigation should exist")

// Tap on the first dehydration entry
let button = app.buttons["Heart icon, Dehydration Symptoms, Next page, 3/9/25, 3/10/25, 3/11/25, 3/12/25, 3/13/25"]
let button = app.buttons["dehydrationSummaryView"]
button.tap()

// Check if "Dehydration Symptoms" title and sample dehydration alert exist
Expand Down