Update ListUpdateableHelper.java

Author: kchprog

src/main/java/org/hydev/mcpm/client/list/ListUpdateableHelper.java

@@ -36,7 +36,8 @@ public ArrayList<String> listUpdateable(
 
         // Generates a list of PluginVersionStates from the installed plugins obtained
         // from the
-        // SuperLocalPluginTracker instance
+        // SuperLocalPluginTracker instance. Creates a valid input to
+        // CheckForUpdatesBoundary
 
         for (PluginTrackerModel installedModel : installedModels) {
             PluginVersionId pluginVersionId = new PluginVersionId(
@@ -50,12 +51,12 @@ public ArrayList<String> listUpdateable(
 
         CheckForUpdatesInput input = new CheckForUpdatesInput(temp, false);
 
+        CheckForUpdatesResult rawResult = checkForUpdatesBoundary.updates(input);
+
         // Read the list of installedModels and create a CheckForUpdatesInput object
         // with state equal
         // to the list of PluginTrackerModels's version
 
-        CheckForUpdatesResult rawResult = checkForUpdatesBoundary.updates(input);
-
         if (rawResult.state() == CheckForUpdatesResult.State.SUCCESS) {
             ArrayList<String> outdatedNames = new ArrayList<>();
 
@@ -65,15 +66,9 @@ public ArrayList<String> listUpdateable(
                 outdated.add(pluginModel.getLatestPluginVersion().get().meta().name());
             }
             return outdatedNames;
-
-            // filter the installed plugins by the outdated ids
-
         }
 
         return new ArrayList<>();
-        // Need to associate the IDs of the outdated plugins with the installed plugin
-        // YML files, and return all matches
-
     }
 
 }