Skip to content

Remove duplication issue on adding child to RTDB #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove duplication issue on adding child to RTDB #298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions database/useList.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import {
DataSnapshot,
off,
onChildAdded as firebaseOnChildAdded,
onChildChanged as firebaseOnChildChanged,
onChildMoved as firebaseOnChildMoved,
Expand Down Expand Up @@ -97,7 +96,7 @@ export const useList = (query?: Query | null): ListHook => {
}
};

firebaseOnValue(ref, onInitialLoad, onError, { onlyOnce: true });
const valueHandler = firebaseOnValue(ref, onInitialLoad, onError, { onlyOnce: true });
const childChangedHandler = firebaseOnChildChanged(
ref,
onChildChanged,
Expand All @@ -111,10 +110,11 @@ export const useList = (query?: Query | null): ListHook => {
);

return () => {
off(ref, 'child_added', childAddedHandler);
off(ref, 'child_changed', childChangedHandler);
off(ref, 'child_moved', childMovedHandler);
off(ref, 'child_removed', childRemovedHandler);
childAddedHandler?.();
childChangedHandler();
childMovedHandler();
childRemovedHandler();
valueHandler();
};
}, [dispatch, ref]);

Expand Down