Skip to content

Conversation

@Zeitsperre
Copy link
Member

@Zeitsperre Zeitsperre commented Jun 18, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

  • Adds builds that do not compile with NetCDF to the main workflows
  • Substitutes the GitHub Actions tags for commit hashes
  • Adds the step-security/harden-runner action for reducing the attack surface of builds
  • Adds macOS and Windows builds (macOS with and without NetCDF4)
  • Adjusts the CMakeLists.txt to emit fewer warnings

Does this PR introduce a breaking change?

No.

Other information:

The commit hashes will be managed by Dependabot once that integration has been added to the repository.

@Zeitsperre Zeitsperre self-assigned this Jun 18, 2024
@Zeitsperre
Copy link
Member Author

@analytophile

This Pull Request is ready to be merged. The brief summary here is:

  • Pull Requests and commits pushed to the main branch will now trigger both Debug and Release builds for all supported architectures.
  • Failing builds in pull requests will prevent merging to main.

We should perform a "squash" of the commits to not pollute the git history when this is merged.

@Zeitsperre Zeitsperre requested a review from analytophile July 15, 2024 18:49
@Zeitsperre
Copy link
Member Author

@analytophile Just wondering if there's anything needed in order to merge this. All this adds is build checks to ensure that Pull Requests are compiling Raven properly on multiple architecture.

@Zeitsperre
Copy link
Member Author

@huard

This PR adds multiplatform builds to the CI. This does not prevent admins from pushing directly to the main branch. It also provides some small security fixes to the CI.

@huard
Copy link
Collaborator

huard commented Feb 11, 2025

Ideas on how to solve the failed checks ?
Maybe remove #define STANDALONE since it seems to be added by the compiler?

@Zeitsperre
Copy link
Member Author

@huard I can try removing that, but I get the feeling that the issue stems from a missing variable. See #51.

@huard
Copy link
Collaborator

huard commented Feb 11, 2025

You're absolutely right.

@Zeitsperre Zeitsperre merged commit c5261f0 into main Feb 12, 2025
12 checks passed
@Zeitsperre Zeitsperre deleted the multiplatform-builds branch February 12, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants