Skip to content

Conversation

@Zeitsperre
Copy link
Member

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

  • Adds a contributor licensing agreement to satisfy conditions of the Artistic License v2.0
  • Updates the CONTRIBUTING.md file to provide relevant information (removing lorem ipsum stand-in text)
  • Adds a warning for first-time contributors to agree to the contributor licensing agreement

Does this PR introduce a breaking change?

  • No. The project now follows the licensing recommendations much closer to the letter.

Other information:

@Zeitsperre Zeitsperre requested a review from analytophile July 15, 2024 18:50
@Zeitsperre Zeitsperre self-assigned this Jul 15, 2024
Base automatically changed from multiplatform-builds to main February 12, 2025 17:35
Copy link
Collaborator

@analytophile analytophile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Sorry for the late review! Only need to change version number or remove it so this doesn't have to be regularly updated.

@analytophile
Copy link
Collaborator

So I don't break anything with my novice Git status- do you want to update the branch to merge with the main, and I'll merge the pull request afterwards?

@Zeitsperre
Copy link
Member Author

@analytophile Yes, that's exactly how I'll go forward.

Once a Pull Request is "approved", anyone with write access here can merge a Pull Request, so I'll make the remaining changes and merge when it's ready.

Thanks again!

@Zeitsperre Zeitsperre merged commit e6d5299 into main Feb 26, 2025
14 checks passed
@Zeitsperre Zeitsperre deleted the contributor-agreement branch February 26, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants