Skip to content

feat: add 'Drill from Position' functionality to the analysis screen #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

maddavid123
Copy link

@maddavid123 maddavid123 commented Jul 29, 2025

Draft implementation of #185 - incomplete and possibly buggy.
Currently loads the PGN and FEN of the position in the analysis mode into the drill tool.
Current outstanding problems:

  • Does not use the configuration modal, instead hardcodes the Maia model, number of drills and number of moves per drill.
  • Analyses the whole game up to the end of the drill instead of just the moves inside the drill. (Understandable behaviour as the drill tool is only usually used for openings. Would be nice, perhaps as a future PR if we could restrict analysis to only moves played in the drill)

My understanding of typescript/javascript and by extension React/Next.js is very limited (My work usually is embedded C or CLI tasks in C#), so I may have missed better ways of achieving the similar behaviour or trusted the IDE a bit too much where it's unnecessary.

It's late where I am, so will follow up with any feedback/discussion points tomorrow.

fix: handle missing maia analysis from backend
Improve play controls in Play Against Maia + Play Hand & Brain
Copy link

vercel bot commented Jul 29, 2025

Someone is attempting to deploy a commit to the Maia Platform Team on Vercel.

A member of the Team first needs to authorize it.

@maddavid123 maddavid123 changed the base branch from main to dev August 1, 2025 17:35
@kevinjosethomas
Copy link
Member

Let me know if you have the time to complete implementing this; otherwise I'll implement it in my next opening page update

@maddavid123 maddavid123 force-pushed the feat/analysis-drill-from-position branch from f96e4d0 to c665f12 Compare August 7, 2025 18:10
@maddavid123
Copy link
Author

maddavid123 commented Aug 7, 2025

Alright, I think this is ready for review.

Open issues that I'm aware of:
Analysis after drilling is still affecting the entire drill. Seems like this feature would require a partial analysis, though that's beyond me at this point.
Drill ending modals all refer to opening drill results, or similar. I'm thinking the simplest change would be to change the text to remove the word opening in order to make it more generic to the two contexts (openings or custom positions) but naturally requires some level of feedback.

Also, I didn't check how this is viewed on mobile.

@maddavid123 maddavid123 marked this pull request as ready for review August 7, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants