Skip to content

Conversation

@cvrebert
Copy link
Contributor

Fixes #458 and adds a relevant unit test.
Passes both grunt test and the in-browser test (in Chrome).

@nschonni
Copy link
Member

Did you have a chance to test it out with the Rhino CLI? Note that it does fall down for the full suite though due to heap issues.

@cvrebert
Copy link
Contributor Author

@nschonni No, I don't have Rhino.

@nschonni
Copy link
Member

grunt rhino uses the bundled js.jar for the tests, but I don't remember what causes it to hang

@cvrebert
Copy link
Contributor Author

Okay, it seems to pass:

chris@devbox ~/code/csslint (defensive-copy) $ grunt rhino
<other Grunt task output elided>
Running "test_rhino:tests" (test_rhino) task
YUITest for Node.js
....................................................................................................
Total tests: 100, Failures: 0, Skipped: 0, Time: 1.047 seconds


YUITest for Node.js
.............................................................................................................................................................................................................................................................................................................................................................................
Total tests: 365, Failures: 0, Skipped: 0, Time: 11.531 seconds

@cvrebert
Copy link
Contributor Author

Also, in case it wasn't already apparent, #458 is affecting us over at Bootstrap.

@cvrebert
Copy link
Contributor Author

cvrebert commented Apr 2, 2014

@stubbornella I hate to be a bother, but: Ping.

@nschonni
Copy link
Member

nschonni commented Apr 2, 2014

@cvrebert I'm going to be going through all the PRs and seeing what can go into a bugfix release vs the next point release.

@nschonni
Copy link
Member

nschonni commented Apr 8, 2014

@stubbornella https://github.com/pvorb/node-clone/blob/master/clone.js looks to be safe vanilla JS that should work across the various runners. Thoughts on merging this?

@cvrebert I've landed a few things recently, do you mind rebasing again?

@cvrebert
Copy link
Contributor Author

cvrebert commented Apr 8, 2014

@nschonni Rebasing completed.

@nschonni
Copy link
Member

nschonni commented Apr 8, 2014

👍 thanks

@nschonni nschonni added this to the 0.11.0 milestone Apr 9, 2014
@cvrebert
Copy link
Contributor Author

@nschonni Is this still auto-mergeable without conflicts?

@nschonni
Copy link
Member

Nope, I was going to manually merge since it was my fault that I made it unmergable after asking you to rebase 😊
If you want to rebase that's great, otherwise I'll just manually merge the commits in when I get a chance.

@cvrebert
Copy link
Contributor Author

@nschonni Freshly rebased.

nschonni added a commit that referenced this pull request May 11, 2014
copy the passed-in ruleset in verify(); fixes #458
@nschonni nschonni merged commit ea36ad5 into CSSLint:master May 11, 2014
@cvrebert
Copy link
Contributor Author

Praise $DEITY! (and @nschonni)

@XhmikosR XhmikosR modified the milestones: 1.0.0, 0.11.0 Jan 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CSSLint.verify() undocumentedly modifies ruleset argument in-place

3 participants