Skip to content

Make rules understand @viewport #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Make rules understand @viewport #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d25c252
Add a testcase for @viewport rule
hartman Mar 5, 2014
3c02bc6
Make other rules understand and reset based on viewport
hartman Mar 12, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/rules/box-model.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ CSSLint.addRule({
parser.addListener("startpage", startRule);
parser.addListener("startpagemargin", startRule);
parser.addListener("startkeyframerule", startRule);
parser.addListener("startviewport", startRule);

parser.addListener("property", function(event){
var name = event.property.text.toLowerCase();
Expand All @@ -96,6 +97,7 @@ CSSLint.addRule({
parser.addListener("endpage", endRule);
parser.addListener("endpagemargin", endRule);
parser.addListener("endkeyframerule", endRule);
parser.addListener("endviewport", endRule);
}

});
});
4 changes: 3 additions & 1 deletion src/rules/display-property-grouping.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ CSSLint.addRule({
parser.addListener("startkeyframerule", startRule);
parser.addListener("startpagemargin", startRule);
parser.addListener("startpage", startRule);
parser.addListener("startviewport", startRule);

parser.addListener("property", function(event){
var name = event.property.text.toLowerCase();
Expand All @@ -111,7 +112,8 @@ CSSLint.addRule({
parser.addListener("endkeyframerule", endRule);
parser.addListener("endpagemargin", endRule);
parser.addListener("endpage", endRule);
parser.addListener("endviewport", endRule);

}

});
});
3 changes: 2 additions & 1 deletion src/rules/duplicate-properties.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ CSSLint.addRule({
parser.addListener("startpage", startRule);
parser.addListener("startpagemargin", startRule);
parser.addListener("startkeyframerule", startRule);
parser.addListener("startviewport", startRule);

parser.addListener("property", function(event){
var property = event.property,
Expand All @@ -43,4 +44,4 @@ CSSLint.addRule({

}

});
});
3 changes: 2 additions & 1 deletion src/rules/fallback-colors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ CSSLint.addRule({
parser.addListener("startpage", startRule);
parser.addListener("startpagemargin", startRule);
parser.addListener("startkeyframerule", startRule);
parser.addListener("startviewport", startRule);

parser.addListener("property", function(event){
var property = event.property,
Expand Down Expand Up @@ -74,4 +75,4 @@ CSSLint.addRule({

}

});
});
4 changes: 3 additions & 1 deletion src/rules/outline-none.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ CSSLint.addRule({
parser.addListener("startpage", startRule);
parser.addListener("startpagemargin", startRule);
parser.addListener("startkeyframerule", startRule);
parser.addListener("startviewport", startRule);

parser.addListener("property", function(event){
var name = event.property.text.toLowerCase(),
Expand All @@ -67,7 +68,8 @@ CSSLint.addRule({
parser.addListener("endpage", endRule);
parser.addListener("endpagemargin", endRule);
parser.addListener("endkeyframerule", endRule);
parser.addListener("endviewport", endRule);

}

});
});
4 changes: 3 additions & 1 deletion src/rules/vendor-prefix.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ CSSLint.addRule({
parser.addListener("startpage", startRule);
parser.addListener("startpagemargin", startRule);
parser.addListener("startkeyframerule", startRule);
parser.addListener("startviewport", startRule);

parser.addListener("property", function(event){
var name = event.property.text.toLowerCase();
Expand All @@ -138,6 +139,7 @@ CSSLint.addRule({
parser.addListener("endpage", endRule);
parser.addListener("endpagemargin", endRule);
parser.addListener("endkeyframerule", endRule);
parser.addListener("endviewport", endRule);
}

});
});
5 changes: 5 additions & 0 deletions tests/all-rules.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@
this.options[rules[i].id] = 1;
},

"Using @viewport should not result in an error": function(){
var result = CSSLint.verify("@viewport { width: auto; }", this.options);
Assert.areEqual(0, result.messages.length);
},

"Using @keyframes should not result in an error": function(){
var result = CSSLint.verify("@keyframes resize { 0% {padding: 0;} 50% {padding: 0;} 100% {padding: 0;}}", this.options);
Assert.areEqual(0, result.messages.length);
Expand Down