Skip to content

optional space between /* and csslint in embedded ruleset; fixes #549 #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 9, 2016
Merged

optional space between /* and csslint in embedded ruleset; fixes #549 #598

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b151cb1
optional space between /* and csslint in embedded ruleset; fixes #549
May 29, 2015
b65a662
update regex for accepting whitespace in embedded rulesets #549
Jun 2, 2015
860a9ce
add test specs for whitespace in embedded rulesets #549
Jun 2, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/CSSLint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ var CSSLint = (function(){

var rules = [],
formatters = [],
embeddedRuleset = /\/\*csslint([^\*]*)\*\//,
embeddedRuleset = /\/\*\s?csslint([^\*]*)\*\//,
Copy link

@bwinton bwinton Jun 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not allow more than one space in the embedded ruleset? (i.e. use "*" instead of "?")

Also, it would be cool if you could add a test to tests/core/CSSLint.js to make sure the behaviour works the way you expect. 😉 Something like:

"Spaces should be allowed in embedded rulesets": function(){
    var result = CSSLint.verify("/* csslint bogus, adjoining-classes:true, box-sizing:false */\n.foo.bar{}", {
      "text-indent": 1,
      "box-sizing": 1
    });

    Assert.areEqual(2, result.ruleset["adjoining-classes"]);
    Assert.areEqual(1, result.ruleset["text-indent"]);
    Assert.areEqual(0, result.ruleset["box-sizing"]);
}

would work.

api = new parserlib.util.EventTarget();

api.version = "@VERSION@";
Expand Down